test changes

Author: mifu67

src/sentry/workflow_engine/migrations/0038_migrate_metric_alerts.py

@@ -73,6 +73,23 @@ class AlertRuleActivityType(Enum):
     DEACTIVATED = 8
 
 
+class ActionTarget(IntEnum):
+    """
+    Explains the contents of target_identifier
+    """
+
+    # The target_identifier is a direct reference used by the service (e.g. email address, slack channel id)
+    SPECIFIC = 0
+    # The target_identifier is an id from the User model in Sentry
+    USER = 1
+    # The target_identifier is an id from the Team model in Sentry
+    TEAM = 2
+    # The target_identifier is an id from the SentryApp model in Sentry
+    SENTRY_APP = 3
+    # There is no target_identifier, but we want to send notifications to the issue owners
+    ISSUE_OWNERS = 4
+
+
 class ActionType(StrEnum):
     SLACK = "slack"
     MSTEAMS = "msteams"
@@ -94,6 +111,16 @@ class ActionType(StrEnum):
     WEBHOOK = "webhook"
 
 
+class SentryAppIdentifier(StrEnum):
+    """
+    SentryAppIdentifier is an enum that represents the identifier for a Sentry app.
+    """
+
+    SENTRY_APP_INSTALLATION_UUID = "sentry_app_installation_uuid"
+    SENTRY_APP_SLUG = "sentry_app_slug"
+    SENTRY_APP_ID = "sentry_app_id"
+
+
 FIELDS_TO_DETECTOR_FIELDS = {
     "name": "name",
     "description": "description",
@@ -249,11 +276,7 @@ def _migrate_trigger_action(apps: Apps, trigger_action: Any, condition_group_id:
                 priority = config.get("priority", default_priority)
                 data = dataclasses.asdict(OnCallDataBlob(priority=priority))
     else:
-        data = {
-            "type": trigger_action.type,
-            "sentry_app_id": trigger_action.sentry_app_id,
-            "sentry_app_config": trigger_action.sentry_app_config,
-        }
+        data = {}
 
     # get target identifier
     if action_type == ActionType.SENTRY_APP:
@@ -267,16 +290,22 @@ def _migrate_trigger_action(apps: Apps, trigger_action: Any, condition_group_id:
     else:
         target_identifier = trigger_action.target_identifier
 
+    # build config
+    target_type = trigger_action.target_type
+    config = {
+        "target_display": trigger_action.target_display,
+        "target_identifier": target_identifier,
+        "target_type": target_type,
+    }
+    if target_type == ActionTarget.SENTRY_APP.value:
+        config["sentry_app_identifier"] = SentryAppIdentifier.SENTRY_APP_ID
+
     # create the models
     action = Action.objects.create(
         type=action_type,
         data=data,
         integration_id=trigger_action.integration_id,
-        config={
-            "target_display": trigger_action.target_display,
-            "target_identifier": target_identifier,
-            "target_type": trigger_action.target_type,
-        },
+        config=config,
     )
     DataConditionGroupAction.objects.create(
         condition_group_id=condition_group_id,

tests/sentry/workflow_engine/migrations/test_0038_migrate_metric_alerts.py

@@ -345,11 +345,7 @@ def test_simple_trigger_action(self):
             action=action.id,
         )
         assert action.type == Action.Type.EMAIL
-        assert action.data == {
-            "type": self.email_action.type,
-            "sentry_app_id": self.email_action.sentry_app_id,
-            "sentry_app_config": self.email_action.sentry_app_config,
-        }
+        assert action.data == {}
         assert action.integration_id is None
         assert action.config.get("target_display") is None
         assert action.config.get("target_identifier") == self.email_action.target_identifier
@@ -410,6 +406,7 @@ def test_sentry_app_trigger_action(self):
         assert action.config.get("target_display") == self.sentry_app_action.target_display
         assert action.config.get("target_identifier") == self.sentry_app_action.target_identifier
         assert action.config.get("target_type") == self.sentry_app_action.target_type
+        assert action.config.get("sentry_app_identifier") == "sentry_app_id"
 
     def test_skip_dynamic_rule(self):
         assert not AlertRuleDetector.objects.filter(alert_rule=self.dynamic_rule).exists()