Skip to content

Commit b8e7c61

Browse files
authoredMar 18, 2025
feat(ui): Display labels in cron and uptime create forms (#87330)
For things like Project, Environment, Name do not hide the label to help indicate that it's required
1 parent a4a0791 commit b8e7c61

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed
 

‎static/app/views/alerts/rules/uptime/uptimeAlertForm.tsx

-4
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) {
156156
name="projectSlug"
157157
label={t('Project')}
158158
placeholder={t('Choose Project')}
159-
hideLabel
160159
projects={projects}
161160
valueIsSlug
162161
inline={false}
@@ -169,7 +168,6 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) {
169168
label={t('Environment')}
170169
placeholder={t('Select an environment')}
171170
noOptionsMessage={() => t('Start typing to create an environment')}
172-
hideLabel
173171
onCreateOption={(env: any) => {
174172
setNewEnvironment(env);
175173
formModel.setValue('environment', env);
@@ -317,7 +315,6 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) {
317315
<TextField
318316
name="name"
319317
label={t('Uptime rule name')}
320-
hideLabel
321318
placeholder={t('Uptime rule name')}
322319
inline={false}
323320
flexibleControlStateSize
@@ -327,7 +324,6 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) {
327324
<SentryMemberTeamSelectorField
328325
name="owner"
329326
label={t('Owner')}
330-
hideLabel
331327
menuPlacement="auto"
332328
inline={false}
333329
flexibleControlStateSize

‎static/app/views/monitors/components/monitorForm.tsx

-3
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,6 @@ function MonitorForm({
260260
<TextField
261261
name="name"
262262
label={t('Name')}
263-
hideLabel
264263
placeholder={t('My Cron Job')}
265264
required
266265
stacked
@@ -270,7 +269,6 @@ function MonitorForm({
270269
<TextField
271270
name="slug"
272271
label={t('Slug')}
273-
hideLabel
274272
help={tct(
275273
'The [strong:monitor-slug] is used to uniquely identify your monitor within your organization. Changing this slug will require updates to any instrumented check-in calls.',
276274
{strong: <strong />}
@@ -285,7 +283,6 @@ function MonitorForm({
285283
<SentryProjectSelectorField
286284
name="project"
287285
label={t('Project')}
288-
hideLabel
289286
groupProjects={project =>
290287
platformsWithGuides.includes(project.platform) ? 'suggested' : 'other'
291288
}

0 commit comments

Comments
 (0)