Skip to content

Commit c85bde8

Browse files
authored
ref(views): Do not use saved search/issue view default query when stacked nav is enabled (#87206)
This PR disables the `savedSearch` query param (confusingly, by setting it to '1') if the stacked nav user setting is enabled. This is because hitting issues always puts you into the "Feed" section, which always has the default, prioritized query.
1 parent feb2fd1 commit c85bde8

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

static/app/views/issueList/overview.tsx

+11-4
Original file line numberDiff line numberDiff line change
@@ -316,9 +316,10 @@ function IssueListOverview({router}: Props) {
316316
...getEndpointParams(),
317317
limit: MAX_ITEMS,
318318
shortIdLookup: 1,
319-
savedSearch: savedSearchLoading
320-
? savedSearchLookupEnabled
321-
: savedSearchLookupDisabled,
319+
savedSearch:
320+
savedSearchLoading && !prefersStackedNav
321+
? savedSearchLookupEnabled
322+
: savedSearchLookupDisabled,
322323
};
323324

324325
if (selectedSearchId) {
@@ -343,7 +344,13 @@ function IssueListOverview({router}: Props) {
343344
params.collapse = ['stats', 'unhandled'];
344345

345346
return params;
346-
}, [getEndpointParams, location.query, savedSearchLoading, selectedSearchId]);
347+
}, [
348+
getEndpointParams,
349+
location.query,
350+
savedSearchLoading,
351+
selectedSearchId,
352+
prefersStackedNav,
353+
]);
347354

348355
const loadFromCache = useCallback((): boolean => {
349356
const cache = IssueListCacheStore.getFromCache(requestParams);

0 commit comments

Comments
 (0)