Skip to content

Commit d0c9dee

Browse files
authored
chore(seer grouping): Small fixes to Seer circuit breaker defaults (#87255)
This adds two explanatory comments to the Seer similarity circuit breaker config. It also removes the incorrect `ALLOW_EMPTY` flag, since it cannot, in fact, be an empty dictionary.
1 parent 2cdca34 commit d0c9dee

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/sentry/options/defaults.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -985,15 +985,19 @@
985985
flags=FLAG_ALLOW_EMPTY | FLAG_AUTOMATOR_MODIFIABLE,
986986
)
987987

988+
# Note: This is based on US volume. Since other regions are lower-traffic, this effectively means
989+
# the circuit breaker is disabled for any region without its own values configured (you can hardly
990+
# have 33K Seer errors if you don't even have 33K events, so the breaker will never be tripped in
991+
# smaller regions relying on the default).
988992
register(
989993
"seer.similarity.circuit-breaker-config",
990994
type=Dict,
991995
default={
992-
"error_limit": 33250,
996+
"error_limit": 33250, # 95% error rate * avg volume of ~35K events with new hashes/10 min
993997
"error_limit_window": 600, # 10 min
994998
"broken_state_duration": 300, # 5 min
995999
},
996-
flags=FLAG_ALLOW_EMPTY | FLAG_AUTOMATOR_MODIFIABLE,
1000+
flags=FLAG_AUTOMATOR_MODIFIABLE,
9971001
)
9981002

9991003
register(

0 commit comments

Comments
 (0)