Skip to content

Commit d901a5f

Browse files
authored
fix(insights): Add missing text value to database options (#87191)
1 parent 6bdd7dd commit d901a5f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

static/app/views/insights/common/views/spans/selectors/actionSelector.tsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import type {ReactNode} from 'react';
22
import type {Location} from 'history';
33
import omit from 'lodash/omit';
44

5-
import {CompactSelect} from 'sentry/components/compactSelect';
5+
import {CompactSelect, type SelectOption} from 'sentry/components/compactSelect';
66
import {t} from 'sentry/locale';
77
import {trackAnalytics} from 'sentry/utils/analytics';
88
import EventView from 'sentry/utils/discover/eventView';
@@ -50,7 +50,7 @@ export function ActionSelector({value = '', moduleName, spanCategory, filters}:
5050
referrer: 'api.starfish.get-span-actions',
5151
});
5252

53-
const options = useHTTPActions
53+
const options: Array<SelectOption<string>> = useHTTPActions
5454
? HTTP_ACTION_OPTIONS
5555
: [
5656
{value: '', label: 'All'},
@@ -69,6 +69,7 @@ export function ActionSelector({value = '', moduleName, spanCategory, filters}:
6969
{t('(No Detected %s)', LABEL_FOR_MODULE_NAME[moduleName])}
7070
</EmptyContainer>
7171
),
72+
textValue: t('(No Detected %s)', LABEL_FOR_MODULE_NAME[moduleName]),
7273
},
7374
];
7475

@@ -102,7 +103,7 @@ export function ActionSelector({value = '', moduleName, spanCategory, filters}:
102103
);
103104
}
104105

105-
const HTTP_ACTION_OPTIONS = [
106+
const HTTP_ACTION_OPTIONS: Array<SelectOption<string>> = [
106107
{value: '', label: 'All'},
107108
...['GET', 'POST', 'PUT', 'DELETE'].map(action => ({
108109
value: action,

0 commit comments

Comments
 (0)