Skip to content

Commit ed8c6fc

Browse files
committed
fix last_viewed serializability
1 parent 2251fff commit ed8c6fc

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/sentry/issues/endpoints/organization_group_search_views.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def put(self, request: Request, organization: Organization) -> Response:
176176
user_id=request.user.id,
177177
group_search_view_id__in=[view.id for view in new_view_state],
178178
)
179-
last_visited_map = {lv.group_search_view_id: lv for lv in last_visited_views}
179+
last_visited_map = {lv.group_search_view_id: lv.last_visited for lv in last_visited_views}
180180

181181
return self.paginate(
182182
request=request,

tests/sentry/issues/endpoints/test_organization_group_search_views.py

+17
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,23 @@ def test_adds_view_with_no_id(self) -> None:
285285
assert starred_views[idx].position == view["position"]
286286
assert str(starred_views[idx].group_search_view.id) == view["id"]
287287

288+
@with_feature({"organizations:issue-stream-custom-views": True})
289+
@with_feature({"organizations:global-views": True})
290+
@freeze_time("2025-03-07T00:00:00Z")
291+
def test_response_with_last_visited(self) -> None:
292+
GroupSearchViewLastVisited.objects.create(
293+
user_id=self.user.id,
294+
organization=self.organization,
295+
group_search_view=self.base_data["user_one_views"][0],
296+
last_visited=timezone.now(),
297+
)
298+
299+
views = self.client.get(self.url).data
300+
response = self.get_success_response(self.organization.slug, views=views)
301+
302+
assert response.data[0]["lastVisited"] == timezone.now()
303+
assert response.data[1]["lastVisited"] is None
304+
288305
@with_feature({"organizations:issue-stream-custom-views": True})
289306
@with_feature({"organizations:global-views": True})
290307
def test_reorder_views(self) -> None:

0 commit comments

Comments
 (0)