Merge branch 'master' into ryan953/insights-session-health-layout-ref

Author: ryan953

.github/CODEOWNERS

@@ -171,6 +171,8 @@ yarn.lock                                                @getsentry/owners-js-de
 /static/app/views/alerts/                                 @getsentry/alerts-notifications
 /static/app/views/alerts/rules/uptime                     @getsentry/crons
 /static/app/views/releases/                               @getsentry/alerts-notifications
+/static/app/views/releases/drawer/                        @getsentry/replay-frontend
+/static/app/views/releases/releaseBubbles/                @getsentry/replay-frontend
 /src/sentry/rules/processing/delayed_processing.py        @getsentry/alerts-notifications
 
 /static/app/views/settings/account/notifications/         @getsentry/alerts-notifications
@@ -329,12 +331,11 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py     @ge
 
 
 ## Replays
-/static/app/views/releases/drawer/  @getsentry/replay-frontend
-/static/app/components/replays/     @getsentry/replay-frontend
-/static/app/utils/replays/          @getsentry/replay-frontend
-/static/app/views/replays/          @getsentry/replay-frontend
-/src/sentry/replays/                @getsentry/replay-backend
-/tests/sentry/replays/              @getsentry/replay-backend
+/static/app/components/replays/                             @getsentry/replay-frontend
+/static/app/utils/replays/                                  @getsentry/replay-frontend
+/static/app/views/replays/                                  @getsentry/replay-frontend
+/src/sentry/replays/                                        @getsentry/replay-backend
+/tests/sentry/replays/                                      @getsentry/replay-backend
 ## End of Replays
 
 

src/sentry/api/endpoints/api_tokens.py

@@ -13,7 +13,6 @@
 from sentry.api.authentication import SessionNoAuthTokenAuthentication
 from sentry.api.base import Endpoint, control_silo_endpoint
 from sentry.api.exceptions import ResourceDoesNotExist
-from sentry.api.fields import MultipleChoiceField
 from sentry.api.permissions import SentryIsAuthenticated
 from sentry.api.serializers import serialize
 from sentry.auth.elevated_mode import has_elevated_mode
@@ -27,7 +26,7 @@
 
 class ApiTokenSerializer(serializers.Serializer):
     name = CharField(max_length=255, allow_blank=True, required=False)
-    scopes = MultipleChoiceField(required=True, choices=settings.SENTRY_SCOPES)
+    scopes = serializers.MultipleChoiceField(required=True, choices=list(settings.SENTRY_SCOPES))
 
 
 def get_appropriate_user_id(request: Request) -> int:

src/sentry/api/fields/__init__.py

@@ -2,7 +2,6 @@
 from .avatar import *  # noqa: F401,F403
 from .empty_decimal import *  # noqa: F401,F403
 from .empty_integer import *  # noqa: F401,F403
-from .multiplechoice import *  # noqa: F401,F403
 from .sentry_slug import *  # noqa: F401,F403
 from .serializedfile import *  # noqa: F401,F403
 from .user import *  # noqa: F401,F403

src/sentry/api/fields/multiplechoice.py

@@ -1,3 +1,4 @@
+import logging
 from collections import defaultdict
 from datetime import datetime, timedelta, timezone
 from typing import Any, TypedDict
@@ -13,12 +14,16 @@
 from sentry.search.events.fields import get_function_alias
 from sentry.search.events.types import SnubaParams
 from sentry.snuba.entity_subscription import apply_dataset_query_conditions
+from sentry.snuba.metrics import parse_mri_field
 from sentry.snuba.metrics.extraction import MetricSpecType
 from sentry.snuba.metrics_performance import timeseries_query
 from sentry.snuba.models import SnubaQuery
+from sentry.snuba.referrer import Referrer
 from sentry.snuba.spans_rpc import run_timeseries_query
 from sentry.utils.snuba import SnubaTSResult
 
+logger = logging.getLogger(__name__)
+
 
 class TSResultForComparison(TypedDict):
     result: SnubaTSResult
@@ -40,7 +45,7 @@ def make_rpc_request(
         snuba_params,
         query_string=query_parts["query"],
         y_axes=query_parts["selected_columns"],
-        referrer="job-runner.compare-timeseries",
+        referrer=Referrer.JOB_COMPARE_TIMESERIES.value,
         granularity_secs=time_window,
         config=SearchResolverConfig(),
     )
@@ -62,7 +67,7 @@ def make_snql_request(
         query,
         snuba_params=snuba_params,
         rollup=time_window,
-        referrer="job-runner.compare-timeseries",
+        referrer=Referrer.JOB_COMPARE_TIMESERIES.value,
         on_demand_metrics_enabled=on_demand_metrics_enabled,
         on_demand_metrics_type=MetricSpecType.SIMPLE_QUERY,
         zerofill_results=True,
@@ -86,7 +91,7 @@ def fill_aligned_series(data: dict[str, Any], alias: str, key: str):
     return aligned_results
 
 
-def assert_timeseries_close(aligned_timeseries):
+def assert_timeseries_close(aligned_timeseries, alert_rule):
     mismatches: dict[int, dict[str, float]] = {}
     missing_buckets = 0
     for timestamp, values in aligned_timeseries.items():
@@ -116,12 +121,22 @@ def assert_timeseries_close(aligned_timeseries):
     if mismatches:
         with sentry_sdk.isolation_scope() as scope:
             scope.set_extra("mismatches", mismatches)
+            scope.set_extra("alert_id", alert_rule.id)
             sentry_sdk.capture_message("Timeseries mismatch", level="info")
+            logger.info("Alert %s has too many mismatches", alert_rule.id)
+
+            return False, mismatches
 
     if missing_buckets > 1:
-        sentry_sdk.capture_message("Multiple missing buckets!", level="info")
+        with sentry_sdk.isolation_scope() as scope:
+            scope.set_extra("alert_id", alert_rule.id)
+            sentry_sdk.capture_message("Multiple missing buckets", level="info")
+            logger.info("Alert %s has multiple missing buckets", alert_rule.id)
+
+            return False, mismatches
 
-    return mismatches
+    logger.info("Alert %s timeseries is close", alert_rule.id)
+    return True, mismatches
 
 
 def compare_timeseries_for_alert_rule(alert_rule: AlertRule):
@@ -130,6 +145,22 @@ def compare_timeseries_for_alert_rule(alert_rule: AlertRule):
     if not project:
         raise NoProjects
 
+    if snuba_query.aggregate in ["apdex()"]:
+        logger.info(
+            "Skipping alert %s, %s aggregate not yet supported by RPC",
+            alert_rule.id,
+            snuba_query.aggregate,
+        )
+        return {"skipped": True, "is_close": False}
+
+    if parse_mri_field(snuba_query.aggregate):
+        logger.info(
+            "Skipping alert %s, %s, MRI fields not supported in aggregates",
+            alert_rule.id,
+            snuba_query.aggregate,
+        )
+        return {"skipped": True, "is_close": False}
+
     organization = Organization.objects.get_from_cache(id=project.organization_id)
 
     on_demand_metrics_enabled = features.has(
@@ -139,8 +170,13 @@ def compare_timeseries_for_alert_rule(alert_rule: AlertRule):
 
     # Align time to the nearest hour because RPCs roll up on exact timestamps.
     now = datetime.now(tz=timezone.utc).replace(minute=0, second=0, microsecond=0)
+
+    environments = []
+    if snuba_query.environment:
+        environments = [snuba_query.environment]
+
     snuba_params = SnubaParams(
-        environments=[snuba_query.environment],
+        environments=environments,
         projects=[project],
         organization=organization,
         start=now - timedelta(days=1),
@@ -164,4 +200,6 @@ def compare_timeseries_for_alert_rule(alert_rule: AlertRule):
 
     aligned_timeseries = align_timeseries(snql_result=snql_result, rpc_result=rpc_result)
 
-    return assert_timeseries_close(aligned_timeseries)
+    is_close, mismatches = assert_timeseries_close(aligned_timeseries, alert_rule)
+
+    return {"is_close": is_close, "skipped": False, "mismatches": mismatches}

src/sentry/discover/compare_timeseries.py

@@ -4,6 +4,7 @@
 
 from sentry.api.event_search import event_search_grammar
 from sentry.search.events import fields
+from sentry.snuba.metrics import parse_mri
 
 
 class QueryParts(TypedDict):
@@ -20,6 +21,10 @@ def apply_is_segment_condition(query: str) -> str:
 
 
 def column_switcheroo(term):
+    parsed_mri = parse_mri(term)
+    if parsed_mri:
+        term = parsed_mri.name
+
     if term == "transaction.duration":
         return "span.duration"
 

src/sentry/discover/translation/mep_to_eap.py

@@ -483,6 +483,8 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:workflow-engine-issue-alert-dual-write", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable workflow engine for issue alerts
     manager.add("organizations:workflow-engine-process-workflows", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
+    # Enable logging to debug workflow engine process workflows
+    manager.add("organizations:workflow-engine-process-workflows-logs", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable firing actions for workflow engine issue alerts
     manager.add("organizations:workflow-engine-trigger-actions", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable dual writing for metric alert issues (see: alerts create issues)

src/sentry/features/temporary.py

@@ -9,7 +9,7 @@
 from celery import Task
 from django.db.models import OuterRef, Subquery
 
-from sentry import buffer, nodestore
+from sentry import buffer, features, nodestore
 from sentry.buffer.base import BufferField
 from sentry.db import models
 from sentry.eventstore.models import Event, GroupEvent
@@ -465,6 +465,19 @@ def fire_rules(
             groupevent = group_to_groupevent[group]
             rule_fire_history = history.record(rule, group, groupevent.event_id, notification_uuid)
 
+            if features.has(
+                "organizations:workflow-engine-process-workflows-logs",
+                project.organization,
+            ):
+                logger.info(
+                    "post_process.delayed_processing.triggered_rule",
+                    extra={
+                        "rule_id": rule.id,
+                        "group_id": group.id,
+                        "event_id": groupevent.event_id,
+                    },
+                )
+
             callback_and_futures = activate_downstream_actions(
                 rule, groupevent, notification_uuid, rule_fire_history, is_post_process=False
             ).values()

src/sentry/rules/processing/delayed_processing.py

@@ -396,6 +396,21 @@ def apply_rule(self, rule: Rule, status: GroupRuleStatus) -> None:
                 organization_id=rule.project.organization.id,
                 rule_id=rule.id,
             )
+
+        if features.has(
+            "organizations:workflow-engine-process-workflows-logs",
+            rule.project.organization,
+        ):
+            logger.info(
+                "post_process.process_rules.triggered_rule",
+                extra={
+                    "rule_id": rule.id,
+                    "payload": state,
+                    "group_id": self.group.id,
+                    "event_id": self.event.event_id,
+                },
+            )
+
         notification_uuid = str(uuid.uuid4())
         rule_fire_history = history.record(rule, self.group, self.event.event_id, notification_uuid)
         grouped_futures = activate_downstream_actions(

src/sentry/rules/processing/processor.py

@@ -32,6 +32,38 @@
 )
 
 
+def failure_rate(_: ResolvedArguments) -> Column.BinaryFormula:
+    return Column.BinaryFormula(
+        left=Column(
+            conditional_aggregation=AttributeConditionalAggregation(
+                aggregate=Function.FUNCTION_COUNT,
+                key=AttributeKey(
+                    name="sentry.trace.status",
+                    type=AttributeKey.TYPE_STRING,
+                ),
+                filter=TraceItemFilter(
+                    comparison_filter=ComparisonFilter(
+                        key=AttributeKey(
+                            name="sentry.trace.status",
+                            type=AttributeKey.TYPE_STRING,
+                        ),
+                        op=ComparisonFilter.OP_NOT_IN,
+                        value=AttributeValue(
+                            val_str_array=StrArray(
+                                values=["ok", "cancelled", "unknown"],
+                            ),
+                        ),
+                    )
+                ),
+                label="trace_status_count",
+                extrapolation_mode=ExtrapolationMode.EXTRAPOLATION_MODE_NONE,
+            ),
+        ),
+        op=Column.BinaryFormula.OP_DIVIDE,
+        right=TOTAL_SPAN_COUNT,
+    )
+
+
 def http_response_rate(args: ResolvedArguments) -> Column.BinaryFormula:
     code = cast(Literal[1, 2, 3, 4, 5], args[0])
 
@@ -223,6 +255,12 @@ def ttid_contribution_rate(args: ResolvedArguments) -> Column.BinaryFormula:
         ],
         formula_resolver=trace_status_rate,
     ),
+    "failure_rate": FormulaDefinition(
+        default_search_type="percentage",
+        arguments=[],
+        formula_resolver=failure_rate,
+        is_aggregate=True,
+    ),
     "ttfd_contribution_rate": FormulaDefinition(
         default_search_type="percentage",
         arguments=[],

src/sentry/search/eap/spans/formulas.py

@@ -984,6 +984,8 @@ class Referrer(StrEnum):
     TEST_QUERY = "test_query"
     METRIC_VALIDATION = "metric_validation"
 
+    JOB_COMPARE_TIMESERIES = "job-runner.compare-timeseries"
+
 
 VALUES = {referrer.value for referrer in Referrer}
 

src/sentry/snuba/referrer.py

@@ -46,6 +46,7 @@
 from sentry.workflow_engine.processors.workflow import (
     WORKFLOW_ENGINE_BUFFER_LIST_KEY,
     evaluate_workflows_action_filters,
+    log_fired_workflows,
 )
 from sentry.workflow_engine.types import DataConditionHandler, WorkflowJob
 
@@ -423,6 +424,16 @@ def fire_actions_for_groups(
                 tags={"event_type": group_event.group.type},
             )
 
+        if features.has(
+            "organizations:workflow-engine-process-workflows-logs",
+            organization,
+        ):
+            log_fired_workflows(
+                log_name="workflow_engine.delayed_workflow.fired_workflow",
+                actions=filtered_actions,
+                job=job,
+            )
+
         if features.has(
             "organizations:workflow-engine-trigger-actions",
             organization,