Merge branch 'master' into jferg/remove-internal-multi-choice

Author: JoshFerge

.github/CODEOWNERS

@@ -171,6 +171,8 @@ yarn.lock                                                @getsentry/owners-js-de
 /static/app/views/alerts/                                 @getsentry/alerts-notifications
 /static/app/views/alerts/rules/uptime                     @getsentry/crons
 /static/app/views/releases/                               @getsentry/alerts-notifications
+/static/app/views/releases/drawer/                        @getsentry/replay-frontend
+/static/app/views/releases/releaseBubbles/                @getsentry/replay-frontend
 /src/sentry/rules/processing/delayed_processing.py        @getsentry/alerts-notifications
 
 /static/app/views/settings/account/notifications/         @getsentry/alerts-notifications
@@ -329,11 +331,11 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py     @ge
 
 
 ## Replays
-/static/app/components/replays/   @getsentry/replay-frontend
-/static/app/utils/replays/        @getsentry/replay-frontend
-/static/app/views/replays/        @getsentry/replay-frontend
-/src/sentry/replays/              @getsentry/replay-backend
-/tests/sentry/replays/            @getsentry/replay-backend
+/static/app/components/replays/                             @getsentry/replay-frontend
+/static/app/utils/replays/                                  @getsentry/replay-frontend
+/static/app/views/replays/                                  @getsentry/replay-frontend
+/src/sentry/replays/                                        @getsentry/replay-backend
+/tests/sentry/replays/                                      @getsentry/replay-backend
 ## End of Replays
 
 

migrations_lockfile.txt

@@ -17,7 +17,7 @@ remote_subscriptions: 0003_drop_remote_subscription
 
 replays: 0004_index_together
 
-sentry: 0842_create_organization_member_invite_table
+sentry: 0843_make_groupsearchview_postition_nullable_for_deletion
 
 social_auth: 0002_default_auto_field
 

requirements-base.txt

@@ -65,7 +65,7 @@ requests>=2.32.3
 rfc3339-validator>=0.1.2
 rfc3986-validator>=0.1.1
 # [end] jsonschema format validators
-sentry-arroyo>=2.19.9
+sentry-arroyo>=2.20.0
 sentry-kafka-schemas>=1.1.2
 sentry-ophio==1.0.0
 sentry-protos>=0.1.62

requirements-dev-frozen.txt

@@ -29,7 +29,7 @@ click==8.1.7
 click-didyoumean==0.3.0
 click-plugins==1.1.1
 click-repl==0.3.0
-confluent-kafka==2.3.0
+confluent-kafka==2.8.0
 covdefaults==2.3.0
 coverage==7.6.4
 cronsim==2.6
@@ -180,7 +180,7 @@ rpds-py==0.20.0
 rsa==4.8
 s3transfer==0.10.0
 selenium==4.16.0
-sentry-arroyo==2.19.9
+sentry-arroyo==2.20.0
 sentry-cli==2.16.0
 sentry-covdefaults-disable-branch-coverage==1.0.2
 sentry-devenv==1.16.0

requirements-frozen.txt

@@ -26,7 +26,7 @@ click==8.1.7
 click-didyoumean==0.3.0
 click-plugins==1.1.1
 click-repl==0.3.0
-confluent-kafka==2.3.0
+confluent-kafka==2.8.0
 cronsim==2.6
 cryptography==43.0.1
 cssselect==1.0.3
@@ -123,7 +123,7 @@ rfc3986-validator==0.1.1
 rpds-py==0.20.0
 rsa==4.8
 s3transfer==0.10.0
-sentry-arroyo==2.19.9
+sentry-arroyo==2.20.0
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==1.1.2
 sentry-ophio==1.0.0

src/sentry/api/endpoints/group_ai_summary.py

@@ -18,6 +18,7 @@
 from sentry.api.bases.group import GroupEndpoint
 from sentry.api.serializers import EventSerializer, serialize
 from sentry.api.serializers.rest_framework.base import convert_dict_key_case, snake_to_camel_case
+from sentry.autofix.utils import get_autofix_state
 from sentry.constants import ObjectStatus
 from sentry.eventstore.models import Event, GroupEvent
 from sentry.models.group import Group
@@ -240,15 +241,24 @@ def post(self, request: Request, group: Group) -> Response:
                 issue_summary = self._generate_fixability_score(group.id)
 
             if issue_summary.scores.is_fixable:
-                with sentry_sdk.start_span(op="ai_summary.trigger_autofix"):
-                    response = trigger_autofix(
-                        group=group, event_id=event.event_id, user=request.user
-                    )
-
-                    if response.status_code != 202:
-                        # If autofix trigger fails, we don't cache to let it error and we can run again
-                        # This is only temporary for when we're testing this internally.
-                        return response
+                with sentry_sdk.start_span(op="ai_summary.get_autofix_state"):
+                    autofix_state = get_autofix_state(group_id=group.id)
+
+                if (
+                    not autofix_state
+                ):  # Only trigger autofix if we don't have an autofix on this issue already.
+                    with sentry_sdk.start_span(op="ai_summary.trigger_autofix"):
+                        response = trigger_autofix(
+                            group=group,
+                            event_id=event.event_id,
+                            user=request.user,
+                            auto_run_source="issue_summary_fixability",
+                        )
+
+                        if response.status_code != 202:
+                            # If autofix trigger fails, we don't cache to let it error and we can run again
+                            # This is only temporary for when we're testing this internally.
+                            return response
 
         summary_dict = issue_summary.dict()
         summary_dict["event_id"] = event.event_id

src/sentry/api/event_search.py

@@ -6,7 +6,7 @@
 from collections.abc import Callable, Generator, Mapping, Sequence
 from dataclasses import asdict, dataclass, field
 from datetime import datetime
-from typing import TYPE_CHECKING, Any, Literal, NamedTuple, TypeIs, Union
+from typing import TYPE_CHECKING, Any, Literal, NamedTuple, TypeIs, Union, overload
 
 from django.utils.functional import cached_property
 from parsimonious.exceptions import IncompleteParseError
@@ -574,8 +574,8 @@ def __str__(self) -> str:
             return f"{self.key.name}{self.operator}{self.value.raw_value}"
 
 
-@dataclass
-class SearchConfig:
+@dataclass  # pycqa/pycodestyle#1277
+class SearchConfig[TAllowBoolean: (Literal[True], Literal[False]) = Literal[True]]:  # noqa: E251
     """
     Configures how the search parser interprets a search query
     """
@@ -604,7 +604,7 @@ class SearchConfig:
     is_filter_translation: Mapping[str, tuple[str, Any]] = field(default_factory=dict)
 
     # Enables boolean filtering (AND / OR)
-    allow_boolean = True
+    allow_boolean: TAllowBoolean = True  # type: ignore[assignment]  # python/mypy#18812
 
     # Allows us to specify an allowlist of keys we will accept for this search.
     # If empty, allow all keys.
@@ -619,8 +619,32 @@ class SearchConfig:
     # Whether to wrap free_text_keys in asterisks
     wildcard_free_text: bool = False
 
+    @overload
     @classmethod
-    def create_from(cls, search_config: SearchConfig, **overrides):
+    def create_from[
+        TBool: (Literal[True], Literal[False])
+    ](
+        cls: type[SearchConfig[Any]],
+        search_config: SearchConfig[Any],
+        *,
+        allow_boolean: TBool,
+        **overrides: Any,
+    ) -> SearchConfig[TBool]: ...
+
+    @overload
+    @classmethod
+    def create_from[
+        TBool: (Literal[True], Literal[False])
+    ](
+        cls: type[SearchConfig[Any]],
+        search_config: SearchConfig[TBool],
+        **overrides: Any,
+    ) -> SearchConfig[TBool]: ...
+
+    @classmethod
+    def create_from(
+        cls: type[SearchConfig[Any]], search_config: SearchConfig[Any], **overrides: Any
+    ) -> SearchConfig[Any]:
         config = cls(**asdict(search_config))
         for key, val in overrides.items():
             setattr(config, key, val)
@@ -632,7 +656,7 @@ class SearchVisitor(NodeVisitor):
 
     def __init__(
         self,
-        config: SearchConfig,
+        config: SearchConfig[Any],
         params: ParamsType | None = None,
         get_field_type: Callable[[str], str | None] | None = None,
         get_function_result_type: Callable[[str], str | None] | None = None,
@@ -1330,16 +1354,36 @@ def generic_visit(self, node, children):
 QueryToken = Union[SearchFilter, AggregateFilter, QueryOp, ParenExpression]
 
 
+@overload
+def parse_search_query(
+    query: str,
+    *,
+    config: SearchConfig[Literal[False]],
+    params=None,
+    get_field_type: Callable[[str], str | None] | None = None,
+    get_function_result_type: Callable[[str], str | None] | None = None,
+) -> Sequence[SearchFilter | AggregateFilter]: ...
+
+
+@overload
+def parse_search_query(
+    query: str,
+    *,
+    config: SearchConfig[Literal[True]] | None = None,
+    params=None,
+    get_field_type: Callable[[str], str | None] | None = None,
+    get_function_result_type: Callable[[str], str | None] | None = None,
+) -> Sequence[QueryToken]: ...
+
+
 def parse_search_query(
     query: str,
     *,
-    config: SearchConfig | None = None,
+    config: SearchConfig[Any] | None = None,
     params=None,
     get_field_type: Callable[[str], str | None] | None = None,
     get_function_result_type: Callable[[str], str | None] | None = None,
-) -> list[
-    SearchFilter
-]:  # TODO: use the `Sequence[QueryToken]` type and update the code that fails type checking.
+) -> Sequence[QueryToken]:
     if config is None:
         config = default_config
 

src/sentry/api/helpers/group_index/index.py

@@ -12,7 +12,7 @@
 from rest_framework.response import Response
 
 from sentry import features, search
-from sentry.api.event_search import SearchFilter
+from sentry.api.event_search import AggregateFilter, SearchFilter
 from sentry.api.issue_search import convert_query_values, parse_search_query
 from sentry.api.serializers import serialize
 from sentry.constants import DEFAULT_SORT_OPTION
@@ -53,7 +53,7 @@ def parse_and_convert_issue_search_query(
     projects: Sequence[Project],
     environments: Sequence[Environment] | None,
     user: User | AnonymousUser,
-) -> Sequence[SearchFilter]:
+) -> Sequence[SearchFilter | AggregateFilter]:
     try:
         search_filters = convert_query_values(
             parse_search_query(query), projects, user, environments
@@ -160,7 +160,7 @@ def build_query_params_from_request(
 
 def validate_search_filter_permissions(
     organization: Organization,
-    search_filters: Sequence[SearchFilter],
+    search_filters: Sequence[AggregateFilter | SearchFilter],
     user: User | AnonymousUser,
 ) -> None:
     """
@@ -178,7 +178,7 @@ def validate_search_filter_permissions(
 
     for search_filter in search_filters:
         for feature_condition, feature_name in advanced_search_features:
-            if feature_condition(search_filter):
+            if isinstance(search_filter, SearchFilter) and feature_condition(search_filter):
                 advanced_search_feature_gated.send_robust(
                     user=user, organization=organization, sender=validate_search_filter_permissions
                 )

src/sentry/api/issue_search.py

@@ -273,6 +273,18 @@ def convert_query_values(
 ) -> list[SearchFilter]: ...
 
 
+# maintain a specific subtype of QueryToken union
+@overload
+def convert_query_values(
+    search_filters: Sequence[AggregateFilter | SearchFilter],
+    projects: Sequence[Project],
+    user: User | RpcUser | AnonymousUser | None,
+    environments: Sequence[Environment] | None,
+    value_converters=value_converters,
+    allow_aggregate_filters=False,
+) -> Sequence[AggregateFilter | SearchFilter]: ...
+
+
 @overload
 def convert_query_values(
     search_filters: Sequence[QueryToken],

src/sentry/api/serializers/models/groupsearchview.py

@@ -13,7 +13,6 @@ class GroupSearchViewSerializerResponse(TypedDict):
     name: str
     query: str
     querySort: SORT_LITERALS
-    position: int
     projects: list[int]
     isAllProjects: bool
     environments: list[str]
@@ -23,6 +22,10 @@ class GroupSearchViewSerializerResponse(TypedDict):
     dateUpdated: str
 
 
+class GroupSearchViewStarredSerializerResponse(GroupSearchViewSerializerResponse):
+    position: int
+
+
 @register(GroupSearchView)
 class GroupSearchViewSerializer(Serializer):
     def __init__(self, *args, **kwargs):
@@ -67,7 +70,6 @@ def serialize(self, obj, attrs, user, **kwargs) -> GroupSearchViewSerializerResp
             "name": obj.name,
             "query": obj.query,
             "querySort": obj.query_sort,
-            "position": obj.position,
             "projects": projects,
             "isAllProjects": is_all_projects,
             "environments": obj.environments,
@@ -86,7 +88,7 @@ def __init__(self, *args, **kwargs):
         self.organization = kwargs.pop("organization", None)
         super().__init__(*args, **kwargs)
 
-    def serialize(self, obj, attrs, user, **kwargs) -> GroupSearchViewSerializerResponse:
+    def serialize(self, obj, attrs, user, **kwargs) -> GroupSearchViewStarredSerializerResponse:
         serialized_view: GroupSearchViewSerializerResponse = serialize(
             obj.group_search_view,
             user,

src/sentry/features/temporary.py

@@ -483,6 +483,8 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:workflow-engine-issue-alert-dual-write", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable workflow engine for issue alerts
     manager.add("organizations:workflow-engine-process-workflows", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
+    # Enable logging to debug workflow engine process workflows
+    manager.add("organizations:workflow-engine-process-workflows-logs", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable firing actions for workflow engine issue alerts
     manager.add("organizations:workflow-engine-trigger-actions", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable dual writing for metric alert issues (see: alerts create issues)