Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Up Code Mapping fails when the file is at the top of the source repository #87044

Open
bruno-garcia opened this issue Mar 13, 2025 · 6 comments

Comments

@bruno-garcia
Copy link
Member

On this event, I clicked on:

Image

Image

I left a feedback in Sentry

Replay at that point in time

Note, I had just added mappings on the GitHub config manually

@getsantry
Copy link
Contributor

getsantry bot commented Mar 13, 2025

Routing to @getsentry/product-owners-issues for triage ⏲️

@bruno-garcia
Copy link
Member Author

Let me know if this isnt' Product: Issues 👁

Copy link

sentry-io bot commented Mar 13, 2025

Sentry Feedback: JAVASCRIPT-2YH9

@lobsterkatie
Copy link
Member

@armenzg, do you know why this could be happening?

@armenzg
Copy link
Member

armenzg commented Mar 19, 2025

I know why. If you look at the replay there's a link to the error.

We currently prevent creating code mappings when the file is at the top of the repository:

or frame_file_path.find("/") == -1

This is because we started doing all work with Python packaged frames, thus, always expecting at least a directory. This was a mistake.

Fixing it would require making sure we have good test coverage to prevent regressions. I tried to play it safe when prototyping but ended up writing a lot of code with this assumption.

@armenzg armenzg changed the title Set Up Code Mapping fails with "Unable to save configuration" Set Up Code Mapping fails when the file is at the top of the source repository Mar 19, 2025
@armenzg
Copy link
Member

armenzg commented Mar 19, 2025

I'm tracking it now as part of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants