Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot filter out or disable "Large Render Blocking Asset" performance setting #87059

Closed
adamreisnz opened this issue Mar 14, 2025 · 7 comments
Closed

Comments

@adamreisnz
Copy link

adamreisnz commented Mar 14, 2025

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. See "Large Render Blocking Asset" issues being raised by Sentry
  2. Follow steps in https://docs.sentry.io/product/issues/issue-details/performance-issues/large-render-blocking-asset/ to try and disable this performance check
  3. Notice that it's impossible to disable
  4. Adding Large Render Blocking Asset as value to the ignoreErrors config also doesn't help

Expected Result

To be able to disable this performance metric/check.

Actual Result

Unable to disable it

Product Area

Performance

Link

https://arist.sentry.io/settings/projects/arist-main-vue/performance/

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Mar 14, 2025

Auto-routing to @getsentry/product-owners-performance for triage ⏲️

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 14, 2025
@gggritso
Copy link
Member

@adamreisnz thanks for raising this!

I will forward this along to the right person, but in the meantime, a few questions, if you don't mind! It's possible to archive any issues you're not interested in, so if you're not interested in this particular issue, you could archive it. Are you getting very many_ of these issues, and archiving is impossible? Also, I'm curious why you're not interested in this issue. Is it too noisy? Incorrect? is the render-blocking asset not fixable?

@adamreisnz
Copy link
Author

Hi @gggritso, thanks for following up, and happy to answer your questions:

It's possible to archive any issues you're not interested in, so if you're not interested in this particular issue, you could archive it.

Sentry will still raise a new issue whenever the name of the render blocking asset changes (because it considers it a different issue). The name of the asset involved changes almost every day (for every release we do), as it has a random hash applied to it.

Are you getting very many_ of these issues, and archiving is impossible?

Yes, they occur daily, and archiving doesn't help as per above.

Also, I'm curious why you're not interested in this issue. Is it too noisy? Incorrect? is the render-blocking asset not fixable?

Basically all of the above. We have a large app with some legacy code that create large bundles, and at the moment these are unfixable. Sometimes this will result in longer than usual load times for users. This is ok, and acceptable to us.

We just want to be able to disable any such warnings that we're not interested in, as they only create noise and distractions for the team – especially so since we use Linear integration and every time this issue comes up, it will (re)open a Linear ticket, put it in Triage/Backlog, etc. It has a large knock-on effect.

To be honest I was very surprised to find there is no option to disable it. I remember in the past Sentry used to be very flexible with allowing us what features to enable/disable if we didn't want to use them.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 14, 2025
@gggritso
Copy link
Member

@adamreisnz understood, thanks! We've turned off that detector for you. You're right, Sentry usually provides UI toggles to turn features on and off. This one is an outlier, and there are plans to make this toggle available to customers, hopefully in the near future.

That said, would you mind providing us with a few more details? Our detectors usually intelligently strip out random hashes from asset filenames, but in this case it's not working. If the stripping was working, you'd only get a small handful of issues and you could archive them instead of turning off the whole feature.

If you could give me a few more details, we could use them to improve the detector for you, and everyone else:

  • what build system are you using to generate the file names
  • are the file name hashes generated by the framework automatically, or are you generating them manually?
  • what is the format of the hashes? What do the filenames look like?

@adamreisnz
Copy link
Author

Thanks @gggritso!

what build system are you using to generate the file names

We're using Vite to build the FE app, although it's integrated through a Rails backend, so also hooked up using Vite Ruby (although that shouldn't make a difference)

are the file name hashes generated by the framework automatically, or are you generating them manually?

Generated automatically

what is the format of the hashes? What do the filenames look like?

Here's three examples of prod asset names:

Image

What we found, is that Sentry seems to group the issues according to what page this happens on. It would then also create a Linear ticket with the "name" of the page, for example:

  • courses-overview
  • my-enrollments
  • settings

Etc. So I think Sentry is using that to differentiate the error tickets? But even if the page is the same, Sentry didn't seem to link the issues together as you can see here:

Image

Hope this helps

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 17, 2025
@gggritso
Copy link
Member

@adamreisnz that does help, thank you very much for sharing that!

@gggritso
Copy link
Member

Closing this issue. See linked issue about improving Vite fingerprinting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants