-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aci): add GET DataConditions endpoint #87111
base: master
Are you sure you want to change the base?
Conversation
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
0ea16df
to
9839f89
Compare
tests/sentry/workflow_engine/endpoints/test_organization_data_condition_index.py
Outdated
Show resolved
Hide resolved
tests/sentry/workflow_engine/endpoints/test_organization_data_condition_index.py
Outdated
Show resolved
Hide resolved
src/sentry/workflow_engine/endpoints/organization_data_condition_index.py
Outdated
Show resolved
Hide resolved
src/sentry/workflow_engine/endpoints/organization_data_condition_index.py
Outdated
Show resolved
Hide resolved
1c56a1b
to
a7d955c
Compare
self.registry = Registry[DataConditionHandler](enable_reverse_lookup=False) | ||
self.registry_patcher = patch( | ||
"sentry.workflow_engine.registry.condition_handler_registry", | ||
new=self.registry, | ||
) | ||
self.registry_patcher.start() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mock the registry here, but this only appears to be working when I run the tests locally (test_group_filter
fails in CI) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by changing the import location!!
853776b
to
b1042ce
Compare
b1042ce
to
c174d72
Compare
0701e49
to
f5fff15
Compare
add GET DataConditions endpoint
/organization/:id_or_slug/data_conditions/
must specify a
type
in the request to filter the results byworkflow_trigger
,action_filter
, ordetector_trigger