-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 chore(noa): invoke all ticketing actions via the issue alert handlers #87372
base: raj/aci/action-group
Are you sure you want to change the base?
🔧 chore(noa): invoke all ticketing actions via the issue alert handlers #87372
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## raj/aci/action-group #87372 +/- ##
======================================================
Coverage 87.73% 87.74%
======================================================
Files 9863 9863
Lines 558658 558387 -271
Branches 22024 22024
======================================================
- Hits 490164 489942 -222
+ Misses 68111 68062 -49
Partials 383 383 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors ticketing actions by funneling them through the issue alert handler and introduces a new TicketingActionHandler abstract base class.
- Implements execute_via_metric_alert_handler to centralize notification handling for ticketing actions.
- Introduces TicketingActionHandler with a dedicated configuration schema for ticketing actions.
- Updates GitHub, GitHub Enterprise, Jira, Jira Server, and Azure Devops action handlers to extend TicketingActionHandler.
Comments suppressed due to low confidence (2)
src/sentry/workflow_engine/handlers/action/notification/handler.py:102
- [nitpick] The configuration schema for 'target_identifier' is defined as type ["null"]. Verify if this is intentional or if a more flexible type (e.g., ["string", "null"]) is expected.
"type": ["null"],
src/sentry/workflow_engine/handlers/action/notification/handler.py:109
- Ensure that ActionTarget is an iterable since using the splat operator (*) requires it to be unpackable.
"enum": [*ActionTarget],
# TODO(iamrajjoshi): Implement this, it should be used for the ticketing actions | ||
pass | ||
""" | ||
This exists so that all ticketing actions can use the same handler as issue alerts since thats the only way we can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider fixing the typo in the docstring: "thats" should be "that's".
This exists so that all ticketing actions can use the same handler as issue alerts since thats the only way we can | |
This exists so that all ticketing actions can use the same handler as issue alerts since that's the only way we can |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
we need all of ticketing actions to flow to the issue alert handler.
this pr defines a new
TicketingActionHandler
ABC to handle invoking the issue alert handlers directly and updates the corresponding implementing classes to use the new ABC.the changes are covered by this, so we should be good