From d662ea16894bb2049499a7eab347cf4b611dca7c Mon Sep 17 00:00:00 2001 From: Colleen O'Rourke Date: Tue, 18 Mar 2025 10:18:04 -0700 Subject: [PATCH 1/2] chore(anomaly detection): Downgrade logger.error to logger.info --- src/sentry/seer/anomaly_detection/get_anomaly_data.py | 4 ++-- .../api/endpoints/test_organization_events_anomalies.py | 4 ++-- tests/sentry/incidents/test_subscription_processor.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/sentry/seer/anomaly_detection/get_anomaly_data.py b/src/sentry/seer/anomaly_detection/get_anomaly_data.py index e466776451bc55..86ab6ffd50ceb5 100644 --- a/src/sentry/seer/anomaly_detection/get_anomaly_data.py +++ b/src/sentry/seer/anomaly_detection/get_anomaly_data.py @@ -92,7 +92,7 @@ def get_anomaly_data_from_seer( return None if response.status > 400: - logger.error( + logger.info( "Error when hitting Seer detect anomalies endpoint", extra={ "response_data": response.data, @@ -129,7 +129,7 @@ def get_anomaly_data_from_seer( return None if not results.get("success"): - logger.error( + logger.info( "Error when hitting Seer detect anomalies endpoint", extra={ "error_message": results.get("message", ""), diff --git a/tests/sentry/api/endpoints/test_organization_events_anomalies.py b/tests/sentry/api/endpoints/test_organization_events_anomalies.py index 7ee64e72a337bd..8963370c103fab 100644 --- a/tests/sentry/api/endpoints/test_organization_events_anomalies.py +++ b/tests/sentry/api/endpoints/test_organization_events_anomalies.py @@ -265,7 +265,7 @@ def test_seer_error(self, mock_logger, mock_seer_request): ) assert mock_seer_request.call_count == 1 - mock_logger.error.assert_called_with( + mock_logger.info.assert_called_with( "Error when hitting Seer detect anomalies endpoint", extra={ "response_data": "Bad stuff", @@ -301,7 +301,7 @@ def test_seer_fail_response(self, mock_logger, mock_seer_request): ) assert mock_seer_request.call_count == 1 - mock_logger.error.assert_called_with( + mock_logger.info.assert_called_with( "Error when hitting Seer detect anomalies endpoint", extra={ "response_data": "I have revolted against my human overlords", diff --git a/tests/sentry/incidents/test_subscription_processor.py b/tests/sentry/incidents/test_subscription_processor.py index 18694fbdddd8b2..ac386269bb747d 100644 --- a/tests/sentry/incidents/test_subscription_processor.py +++ b/tests/sentry/incidents/test_subscription_processor.py @@ -973,7 +973,7 @@ def test_seer_call_bad_status(self, mock_logger, mock_seer_request): last_update=processor.last_update.timestamp(), aggregation_value=10, ) - mock_logger.error.assert_called_with( + mock_logger.info.assert_called_with( "Error when hitting Seer detect anomalies endpoint", extra={ "subscription_id": self.sub.id, From e14b8dcf501710821c41ace31a631cebaed5afd8 Mon Sep 17 00:00:00 2001 From: Colleen O'Rourke Date: Tue, 18 Mar 2025 10:56:41 -0700 Subject: [PATCH 2/2] updated the wrong test --- .../api/endpoints/test_organization_events_anomalies.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/sentry/api/endpoints/test_organization_events_anomalies.py b/tests/sentry/api/endpoints/test_organization_events_anomalies.py index 8963370c103fab..7ee64e72a337bd 100644 --- a/tests/sentry/api/endpoints/test_organization_events_anomalies.py +++ b/tests/sentry/api/endpoints/test_organization_events_anomalies.py @@ -265,7 +265,7 @@ def test_seer_error(self, mock_logger, mock_seer_request): ) assert mock_seer_request.call_count == 1 - mock_logger.info.assert_called_with( + mock_logger.error.assert_called_with( "Error when hitting Seer detect anomalies endpoint", extra={ "response_data": "Bad stuff", @@ -301,7 +301,7 @@ def test_seer_fail_response(self, mock_logger, mock_seer_request): ) assert mock_seer_request.call_count == 1 - mock_logger.info.assert_called_with( + mock_logger.error.assert_called_with( "Error when hitting Seer detect anomalies endpoint", extra={ "response_data": "I have revolted against my human overlords",