You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: .github/pull_request_template.md
+3-3
Original file line number
Diff line number
Diff line change
@@ -20,7 +20,7 @@ _please enter the description of your change here_
20
20
21
21
## Release change checklist
22
22
23
-
A change note ([development_handbook.md#change-notes](https://github.com/github/codeql-coding-standards/blob/main/development_handbook.md#change-notes)) is required for any pull request which modifies:
23
+
A change note ([development_handbook.md#change-notes](https://github.com/github/codeql-coding-standards/blob/main/docs/development_handbook.md#change-notes)) is required for any pull request which modifies:
24
24
25
25
- The structure or layout of the release artifacts.
26
26
- The evaluation performance (memory, execution time) of an existing query.
@@ -44,7 +44,7 @@ For PRs that add new queries or modify existing queries, the following checklist
44
44
-[ ] Have all the relevant rule package description files been checked in?
45
45
-[ ] Have you verified that the metadata properties of each new query is set appropriately?
46
46
-[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
47
-
-[ ] Are the alert messages properly formatted and consistent with the [style guide](https://github.com/github/codeql-coding-standards/blob/main/development_handbook.md#query-style-guide)?
47
+
-[ ] Are the alert messages properly formatted and consistent with the [style guide](https://github.com/github/codeql-coding-standards/blob/main/docs/development_handbook.md#query-style-guide)?
48
48
-[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?<br />_As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process._
49
49
-[ ] Does the query have an appropriate level of in-query comments/documentation?
50
50
-[ ] Have you considered/identified possible edge cases?
@@ -56,7 +56,7 @@ For PRs that add new queries or modify existing queries, the following checklist
56
56
-[ ] Have all the relevant rule package description files been checked in?
57
57
-[ ] Have you verified that the metadata properties of each new query is set appropriately?
58
58
-[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
59
-
-[ ] Are the alert messages properly formatted and consistent with the [style guide](https://github.com/github/codeql-coding-standards/blob/main/development_handbook.md#query-style-guide)?
59
+
-[ ] Are the alert messages properly formatted and consistent with the [style guide](https://github.com/github/codeql-coding-standards/blob/main/docs/development_handbook.md#query-style-guide)?
60
60
-[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?<br />_As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process._
61
61
-[ ] Does the query have an appropriate level of in-query comments/documentation?
62
62
-[ ] Have you considered/identified possible edge cases?
0 commit comments