Make sure all samples are extending the eslint base configs

Author: mjbvz

authenticationprovider-sample/src/extension.ts

@@ -30,6 +30,7 @@ export function activate(context: vscode.ExtensionContext) {
 			const req = await fetch('https://app.vssps.visualstudio.com/_apis/profile/profiles/me?api-version=6.0', {
 				headers: {
 					authorization: `Basic ${Buffer.from(`:${session.accessToken}`).toString('base64')}`,
+					// eslint-disable-next-line @typescript-eslint/naming-convention
 					'content-type': 'application/json',
 				},
 			});
@@ -48,6 +49,3 @@ export function activate(context: vscode.ExtensionContext) {
 
 	context.subscriptions.push(disposable);
 }
-
-// this method is called when your extension is deactivated
-export function deactivate() { }

helloworld-web-sample/.eslintrc.json

@@ -8,6 +8,10 @@
     "plugins": [
         "@typescript-eslint"
     ],
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ],
     "rules": {
         "@typescript-eslint/naming-convention": "warn",
         "@typescript-eslint/semi": "warn",

helloworld-web-sample/src/web/extension.ts

@@ -2,7 +2,7 @@
 // Import the module and reference it with the alias vscode in your code below
 import * as vscode from 'vscode';
 
-// this method is called when your extension is activated
+// This method is called when your extension is activated
 // your extension is activated the very first time the command is executed
 export function activate(context: vscode.ExtensionContext) {
 
@@ -13,7 +13,7 @@ export function activate(context: vscode.ExtensionContext) {
 	// The command has been defined in the package.json file
 	// Now provide the implementation of the command with registerCommand
 	// The commandId parameter must match the command field in package.json
-	let disposable = vscode.commands.registerCommand('helloworld-web-sample.helloWorld', () => {
+	const disposable = vscode.commands.registerCommand('helloworld-web-sample.helloWorld', () => {
 		// The code you place here will be executed every time your command is executed
 
 		// Display a message box to the user
@@ -23,5 +23,7 @@ export function activate(context: vscode.ExtensionContext) {
 	context.subscriptions.push(disposable);
 }
 
-// this method is called when your extension is deactivated
-export function deactivate() { }
+// This method is called when your extension is deactivated
+export function deactivate() {
+	// Noop
+}

l10n-sample/src/extension.ts

@@ -1,6 +1,6 @@
 // The module 'vscode' contains the VS Code extensibility API
 // Import the module and reference it with the alias vscode in your code below
-import path = require('path');
+import * as path from 'path';
 import * as vscode from 'vscode';
 import { sayByeCommand } from './command/sayBye';
 
@@ -35,6 +35,3 @@ export function activate(context: vscode.ExtensionContext) {
 
 	context.subscriptions.push(helloCmd, byeCmd);
 }
-
-// this method is called when your extension is deactivated
-export function deactivate() { }

notebook-extend-markdown-renderer-sample/.eslintrc.json

@@ -12,6 +12,8 @@
         "webpack.config.js"
     ],
     "rules": {
+        "@typescript-eslint/semi": "warn",
+        "semi": "off",
         "@typescript-eslint/no-var-requires": 0
     }
 }

notebook-extend-markdown-renderer-sample/src/emoji.ts

@@ -18,5 +18,5 @@ export async function activate(ctx: RendererContext<void>) {
 	const emoji = require('markdown-it-emoji');
 	markdownItRenderer.extendMarkdownIt((md: MarkdownIt) => {
 		return md.use(emoji, {});
-	})
+	});
 }

notebook-renderer-react-sample/.eslintrc.json

@@ -8,15 +8,22 @@
     "plugins": [
         "@typescript-eslint"
     ],
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ],
     "rules": {
         "@typescript-eslint/naming-convention": "warn",
         "@typescript-eslint/semi": "warn",
         "curly": "warn",
         "eqeqeq": "warn",
         "no-throw-literal": "warn",
-        "semi": "off"
+        "semi": [
+            "error",
+            "always"
+        ]
     },
     "ignorePatterns": [
         "**/*.d.ts"
     ]
-}
+}

notebook-renderer-react-sample/src/client/index.tsx

@@ -23,7 +23,12 @@ export const activate: ActivationFunction = context => {
         root.id = 'root';
         shadow.append(root);
       }
-      const root = shadow.querySelector<HTMLElement>('#root')!;
+
+      const root = shadow.querySelector<HTMLElement>('#root');
+      if (!root) {
+        throw new Error('Could not find root element');
+      }
+
       errorOverlay.wrap(root, () => {
         root.innerHTML = '';
         const node = document.createElement('div');
@@ -32,7 +37,8 @@ export const activate: ActivationFunction = context => {
         ReactDOM.render(<IssuesList info={{ container: node, mime: outputItem.mime, value: outputItem.json(), context }} />, root);
       });
     },
-    disposeOutputItem(outputId) {
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    disposeOutputItem(_outputId) {
       // Do any teardown here. outputId is the cell output being deleted, or
       // undefined if we're clearing all outputs.
     }

notebook-renderer-sample/.eslintrc.json

@@ -8,6 +8,10 @@
     "plugins": [
         "@typescript-eslint"
     ],
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ],
     "rules": {
         "@typescript-eslint/naming-convention": "warn",
         "@typescript-eslint/semi": "warn",
@@ -19,4 +23,4 @@
     "ignorePatterns": [
         "**/*.d.ts"
     ]
-}
+}

notifications-sample/.eslintrc.json

@@ -8,6 +8,10 @@
     "plugins": [
         "@typescript-eslint"
     ],
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ],
     "rules": {
         "@typescript-eslint/naming-convention": "warn",
         "@typescript-eslint/semi": "warn",

uri-handler-sample/.eslintrc.json

@@ -8,6 +8,10 @@
     "plugins": [
         "@typescript-eslint"
     ],
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ],
     "rules": {
         "@typescript-eslint/naming-convention": "warn",
         "@typescript-eslint/semi": "warn",

uri-handler-sample/src/extension.ts

@@ -15,7 +15,7 @@ class MyUriHandler implements vscode.UriHandler {
 
 export function activate(context: vscode.ExtensionContext) {
 
-	let disposable = vscode.commands.registerCommand('uri-handler-sample.start', async () => {
+	const disposable = vscode.commands.registerCommand('uri-handler-sample.start', async () => {
 		// Create our new UriHandler
 		const uriHandler = new MyUriHandler();
 
@@ -31,5 +31,3 @@ export function activate(context: vscode.ExtensionContext) {
 
 	context.subscriptions.push(disposable);
 }
-
-export function deactivate() { }

welcome-view-content-sample/.eslintrc.json

@@ -8,6 +8,10 @@
     "plugins": [
         "@typescript-eslint"
     ],
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ],
     "rules": {
         "@typescript-eslint/naming-convention": "warn",
         "@typescript-eslint/semi": "warn",
@@ -16,4 +20,4 @@
         "no-throw-literal": "warn",
         "semi": "off"
     }
-}
+}

welcome-view-content-sample/src/extension.ts

@@ -1,7 +1,7 @@
 import * as vscode from 'vscode';
 
 export function activate(context: vscode.ExtensionContext) {
-	let disposable = vscode.commands.registerCommand(
+	const disposable = vscode.commands.registerCommand(
 		'welcome-view-content-sample.hello',
 		async () => {
 			vscode.window.showInformationMessage('Hello world!');
@@ -10,5 +10,3 @@ export function activate(context: vscode.ExtensionContext) {
 
 	context.subscriptions.push(disposable);
 }
-
-export function deactivate() { }