"Change highlight color" hotkey conflicts with built-in browser shortcut

[ijgnd]

You use Ctrl+Shift+N which is also used in the anki browser.

"Ctrl+Shift+N" now is used in the browser to focus the editor. In Anki 2.0 "ctrl+shift+f" was used for this action. This the relevant commit from the anki source code from 2017.

I suggest to use a different default shortcut.

Checklist

Please replace the space inside the brackets with an x if the following items apply:

• I've restarted Anki to see if it helps
• I've verified that I use the latest version of the add-on by redownloading it from AnkiWeb
• I've verified that I use the latest version of Anki by checking at https://apps.ankiweb.net#download
• I've tried to disable other add-ons to see if there are any interactions present
• My issue disappears when I hold shift while starting Anki.
• I've checked if anyone else reported this problem before by looking through the issue reports. I also checked to see if there is a section about known issues in the add-on description, documentation, or README.

[KingGemunu]

Having a same issue with the indent and outdent buttons
cmd+shift+[ and cmd+shift+] switch the different open tabs on Anki rather than indenting

[glutanimate]

Thanks for letting me know, guys. Unfortunately it is getting rather difficult to find free hotkey assignments, as they compete both with Anki proper, system defaults, and other add-ons. Especially the last one is really hard to get an overview over, and so I fear that swapping either of these out, while improving the usability in some scenarios, will cause issues in others.

E.g.: If I were to change Ctrl+Shift+N to another hotkey, and that new one does happen to cause a conflict with another add-on, then it could potentially result in more users being affected than right now (considering that users probably spend more time adding cards, and considering users still on earlier versions). Same with the tab switching as this is something specific to macOS, and even on macOS it's likely only a small number of users that use the tab system that are currently affected.

Then there's also the consideration towards existing users and the hotkeys they might be accustomed to...

So yeah, default keyboard assignments aren't my favorite part of add-on development ;)

But let's start with Ctrl+Shift+N: @ijgnd, I feel like at this point you probably have a better grasp of what hotkeys are and what hotkeys aren't typically in use in the add-on sphere. Do you have any particular suggestions on what we could go with here? I guess throwing another keyboard modifier into the mix is always an option, but I wouldn't be surprised if Ctrl+Alt+Shift+N is also used somewhere across the stack.

[ijgnd]

I have no good solution, especially for existing users though. I still think that it's better to not just overwrite built-in commands. I'd at least update the description on ankiweb and link to the "Customize Keyboard Shortcuts" add-on, maybe also an info box on the first startup that also warns about possible conflicts with other add-ons?

I don't think that there are any good shortcuts left. Very few add-ons use two part shortcuts like "Ctrl+t, t". The editor uses "Ctrl,T, ..." and "Ctrl+M, ..." and few add-ons use those so most second keys for those should be free.

"Ctrl+t, ..." is used by two tag-related add-ons, see here and here.