Use get_node when node attribute is not found

[gschwind]

Hello,
instead of making an immediate error of getting a missing attribute of javascript node use this.get_node("attr").
This allow to replace things like :
this.get_node("A/B/C")
or this.get_node("A").get_node("B").get_node("C")
by
this.A.B.C

Shorter code and similar to '$' syntax in GDScript.

Best regards

[ialex32x]

I considered this kind of usage before, but found it may be more harmful than convenient. Because it's confusing if a node has an identical name with the name of the class property/method/field. And it's not strongly typed.
It's better to implement it on the user side in scripts if possible.

[gschwind]

Ok it's fair, in user side I use mixing that use a property node (that could be just $) that do this, i,e. :
this.node.A.B.C
But I did not found how to catch missing attribute without using Proxy, i'm rookie in Javascript :)

[ialex32x]

Snippet looks like this:

Object.defineProperty(Node.prototype, "node", {
    value: new Proxy({}, { get: function (target, key) { ... } } ), 
    enumerable: ...
});

But there is no extension point to get it executed at a proper time (for example, at the first time the Node type is imported). You need to ensure to execute this snippet before you do what = Node.node.x.y.z by yourself.

PS: extension point seems good to help users tweak the internal stuff, I'll add a callback register to make it possible to do something on the user side after a godot type is exposed to javascript.

[ialex32x]

Types can now be modified with require("godot.typeloader").on_type_loaded. You can also configure Entry Script Path in project settings to ensure your injections run before other user scripts.

Write your injection code in res://bootstrap.js (as an example)

// the registered callback will be triggered once the type `Node` loaded
require("godot.typeloader").on_type_loaded("Node", function (type) {
    // static method injection
    type["my_static_func"] = function () {
        console.log("my_static_func_inject");
    }

    // instance method injection
    type.prototype["my_func"] = function () {
        console.log("my_func_inject", this);
    }
});

[gschwind]

look nice thanks !

[Benjamin-Dobell]

@G159w I've submitted a PR which introduces a statically typed get_node API. #55. Feel free to provide feedback on the PR.

Basically it automatically generates types for each scene's node hierarchy. When a scene is saved, the types update automatically. This allows you to do stuff like:

In the above screenshot it's not just aware of the node hierarchy, it knows the type of each node. So it's correctly indicating an error since disabled is a property that exists on CollisionShape3D not StaticBody3D. You also gain auto-completion too: