Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git.github_pr_destination pr_branch parameter doesn't properly insert labels #317

Open
EliteMasterEric opened this issue Mar 14, 2025 · 0 comments

Comments

@EliteMasterEric
Copy link

The PR branch parameter to the Github PR destination currently only supports the ${CONTEXT_REFERENCE}, and has no support for other labels.

As an example, I tried to use this configuration, to make the branch name clear.

    pr_branch = "public/copybara-${GITHUB_PR_USER}-${GITHUB_PR_NUMBER}",

However, instead of the intended result, I got public/copybara-public/copybara-__GITHUB_PR_USER_-public/copybara-__GITHUB_PR_USER_-__GITHUB_PR_NUMBER_-public/copybara-__GITHUB_PR_USER_-__GITHUB_PR_NUMBER_.

I believe the relevant code is located here:

.resolve(e -> e.equals("CONTEXT_REFERENCE") ? contextReference : prBranch);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant