You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use describing names for including but not limited to: variables, functions, defines.
416
+
Use descriptive names for including but not limited to: variables, functions, defines.
417
417
418
418
Make sure that the name is not misleading.
419
419
@@ -597,7 +597,7 @@ void some_func()
597
597
598
598
## ROP chains
599
599
600
-
We prefer collecting target related details like symbol, ROP gadget and stack pivot offsets and structure sizes as `#define`s at the top of the file with describing names.
600
+
We prefer collecting target related details like symbol, ROP gadget and stack pivot offsets and structure sizes as `#define`s at the top of the file with descriptive names.
601
601
602
602
The exact kernel symbols names should be used which could be found in the kernel.
603
603
@@ -730,7 +730,8 @@ void some_func()
730
730
tfd = timerfd_create(CLOCK_MONOTONIC, 0);
731
731
…
732
732
} else {
733
-
// local variable, conflicts with the other local one
733
+
// local variable, conflicts with
734
+
// the other local one
734
735
int tfd;
735
736
…
736
737
// sets a different local variable
@@ -915,7 +916,8 @@ usleep(300*1000);
915
916
```c
916
917
del_chain(trig_chain_name);
917
918
918
-
// @sleep(kernel_func="nft_commit_release", desc="wait for victim chain (trig_chain_name) to be freed")
919
+
// @sleep(kernel_func="nft_commit_release",
920
+
// desc="wait for victim chain (trig_chain_name) to be freed")
0 commit comments