Skip to content

Commit 6e2fbcc

Browse files
committed
Remove assertion that makes test_decider flaky
1 parent 2f44b1a commit 6e2fbcc

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

graphql/backend/tests/test_decider.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
if False:
1616
from typing import Any
1717

18+
from time import sleep
19+
1820

1921
class FakeBackend(GraphQLBackend):
2022
def __init__(self, name, raises=False):
@@ -49,7 +51,7 @@ def test_decider_backend_healthy_backend():
4951
decider_backend = GraphQLDeciderBackend(backend1, backend2)
5052

5153
document = decider_backend.document_from_string(schema, "{ hello }")
52-
assert not backend1.reached
54+
# assert not backend1.reached # this is flaky (race condition)
5355
assert backend2.reached
5456
assert document == "fallback"
5557

@@ -69,18 +71,17 @@ def test_decider_backend_unhealthy_backend():
6971
decider_backend = GraphQLDeciderBackend(backend1, backend2)
7072

7173
document = decider_backend.document_from_string(schema, "{ hello }")
72-
assert not backend1.reached
74+
# assert not backend1.reached # this is flaky (race condition)
7375
assert backend2.reached
7476
assert document == "fallback"
7577

7678
backend1.wait()
7779
backend1.reset()
7880
backend2.reset()
7981
document = decider_backend.document_from_string(schema, "{ hello }")
80-
81-
assert document == "fallback"
8282
assert not backend1.reached
8383
assert not backend2.reached
84+
assert document == "fallback"
8485

8586

8687
def test_decider_old_syntax():

0 commit comments

Comments
 (0)