Skip to content

Commit 94f8e93

Browse files
authoredMar 21, 2025··
otel tracing: fix span names (#11974)
1 parent d60e6fc commit 94f8e93

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed
 

‎opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryTracingModule.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ private void recordOutboundMessageSentEvent(Span span,
446446
if (optionalWireSize != -1 && optionalWireSize != optionalUncompressedSize) {
447447
attributesBuilder.put("message-size-compressed", optionalWireSize);
448448
}
449-
span.addEvent("Outbound message sent", attributesBuilder.build());
449+
span.addEvent("Outbound message", attributesBuilder.build());
450450
}
451451

452452
private void recordInboundCompressedMessage(Span span, int seqNo, long optionalWireSize) {
@@ -460,7 +460,7 @@ private void recordInboundMessageSize(Span span, int seqNo, long bytes) {
460460
AttributesBuilder attributesBuilder = io.opentelemetry.api.common.Attributes.builder();
461461
attributesBuilder.put("sequence-number", seqNo);
462462
attributesBuilder.put("message-size", bytes);
463-
span.addEvent("Inbound message received", attributesBuilder.build());
463+
span.addEvent("Inbound message", attributesBuilder.build());
464464
}
465465

466466
private String generateErrorStatusDescription(io.grpc.Status status) {

‎opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryTracingModuleTest.java

+9-9
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ public void clientBasicTracingMocking() {
231231
List<String> events = eventNameCaptor.getAllValues();
232232
List<io.opentelemetry.api.common.Attributes> attributes = attributesCaptor.getAllValues();
233233
assertEquals(
234-
"Outbound message sent" ,
234+
"Outbound message" ,
235235
events.get(0));
236236
assertEquals(
237237
io.opentelemetry.api.common.Attributes.builder()
@@ -241,7 +241,7 @@ public void clientBasicTracingMocking() {
241241
attributes.get(0));
242242

243243
assertEquals(
244-
"Outbound message sent" ,
244+
"Outbound message" ,
245245
events.get(1));
246246
assertEquals(
247247
io.opentelemetry.api.common.Attributes.builder()
@@ -313,7 +313,7 @@ public void clientBasicTracingRule() {
313313
assertTrue(clientSpanEvents.get(0).getAttributes().isEmpty());
314314

315315
assertEquals(
316-
"Inbound message received" ,
316+
"Inbound message" ,
317317
clientSpanEvents.get(1).getName());
318318
assertEquals(
319319
io.opentelemetry.api.common.Attributes.builder()
@@ -323,7 +323,7 @@ public void clientBasicTracingRule() {
323323
clientSpanEvents.get(1).getAttributes());
324324

325325
assertEquals(
326-
"Inbound message received" ,
326+
"Inbound message" ,
327327
clientSpanEvents.get(2).getName());
328328
assertEquals(
329329
io.opentelemetry.api.common.Attributes.builder()
@@ -342,7 +342,7 @@ public void clientBasicTracingRule() {
342342
assertTrue(clientSpanEvents.get(0).getAttributes().isEmpty());
343343

344344
assertEquals(
345-
"Outbound message sent" ,
345+
"Outbound message" ,
346346
attemptSpanEvents.get(1).getName());
347347
assertEquals(
348348
io.opentelemetry.api.common.Attributes.builder()
@@ -352,7 +352,7 @@ public void clientBasicTracingRule() {
352352
attemptSpanEvents.get(1).getAttributes());
353353

354354
assertEquals(
355-
"Outbound message sent" ,
355+
"Outbound message" ,
356356
attemptSpanEvents.get(2).getName());
357357
assertEquals(
358358
io.opentelemetry.api.common.Attributes.builder()
@@ -518,7 +518,7 @@ public void serverBasicTracingNoHeaders() {
518518
List<EventData> events = spans.get(0).getEvents();
519519
assertEquals(events.size(), 4);
520520
assertEquals(
521-
"Outbound message sent" ,
521+
"Outbound message" ,
522522
events.get(0).getName());
523523
assertEquals(
524524
io.opentelemetry.api.common.Attributes.builder()
@@ -529,7 +529,7 @@ public void serverBasicTracingNoHeaders() {
529529
events.get(0).getAttributes());
530530

531531
assertEquals(
532-
"Outbound message sent" ,
532+
"Outbound message" ,
533533
events.get(1).getName());
534534
assertEquals(
535535
io.opentelemetry.api.common.Attributes.builder()
@@ -549,7 +549,7 @@ public void serverBasicTracingNoHeaders() {
549549
events.get(2).getAttributes());
550550

551551
assertEquals(
552-
"Inbound message received" ,
552+
"Inbound message" ,
553553
events.get(3).getName());
554554
assertEquals(
555555
io.opentelemetry.api.common.Attributes.builder()

0 commit comments

Comments
 (0)
Please sign in to comment.