Skip to content

Commit f3f054a

Browse files
committed
xds: Log cluster_manager config update before applying config
It is confusing/harder to read the logs when the activations/deactivations because of the config happen before the log entry describing the new config.
1 parent d82613a commit f3f054a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

xds/src/main/java/io/grpc/xds/ClusterManagerLoadBalancer.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ protected Map<Object, ResolvedAddresses> createChildAddressesMap(
8181

8282
ClusterManagerConfig config = (ClusterManagerConfig)
8383
resolvedAddresses.getLoadBalancingPolicyConfig();
84+
logger.log(
85+
XdsLogLevel.INFO,
86+
"Received cluster_manager lb config: child names={0}", config.childPolicies.keySet());
8487
Map<Object, ResolvedAddresses> childAddresses = new HashMap<>();
8588

8689
// Reactivate children with config; deactivate children without config
@@ -108,9 +111,6 @@ protected Map<Object, ResolvedAddresses> createChildAddressesMap(
108111
.build();
109112
childAddresses.put(childPolicy.getKey(), addresses);
110113
}
111-
logger.log(
112-
XdsLogLevel.INFO,
113-
"Received cluster_manager lb config: child names={0}", config.childPolicies.keySet());
114114
return childAddresses;
115115
}
116116

0 commit comments

Comments
 (0)