Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards no longer have color when matched #23

Open
Jarvil opened this issue Apr 7, 2017 · 5 comments
Open

Cards no longer have color when matched #23

Jarvil opened this issue Apr 7, 2017 · 5 comments

Comments

@Jarvil
Copy link
Contributor

Jarvil commented Apr 7, 2017

Hello,

I noticed that matched cards are now greyed out instead of keeping the color when they are matched. I would like to see that the color stays since it's helpfull for education purposes, can you give us this option? This option was in Memory Game (1.1.9) but no longer in Memory Game (1.2.1).

@icc
Copy link
Member

icc commented Apr 7, 2017

Hi,
I have made some plans for adding different styling options to the editor. But I'm not sure when I'll get the time for it. For the time being you can override or change the CSS for you site if you want. Here's the style in question: memory-game.css#L127

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 7, 2017

Hello,

I added those styling options to https://moodlesite.com/admin/settings.php?section=themesettingclean
to Custom CSS (theme_clean | customcss) as follow;

.h5p-memory-game .h5p-memory-card.h5p-matched {
  opacity: 1.0;
  filter: grayscale(0%);
}

Greyscale option works but opacity doesn't do anything. Also on iPad iOS 10.something the colors don't work at all with Safari and Chrome.

@icc
Copy link
Member

icc commented Apr 7, 2017

Try using filter: none !important;
Adding !important at the end of any CSS rule ensures that it overrides all others.

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 10, 2017

Hello,

thank you for the reply, now colors work on iOS too 👍 Only thing is that the opacity doesn't

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 10, 2017

Hello,

This worked!

.h5p-memory-game .h5p-memory-card.h5p-matched { opacity: 1.0 !important; filter: none !important; }

👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants