Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different license codes #208

Open
sphistrion opened this issue Feb 26, 2025 · 0 comments
Open

Different license codes #208

sphistrion opened this issue Feb 26, 2025 · 0 comments

Comments

@sphistrion
Copy link

H5P.org's documentation for the library definition (library.json) states that

The same license codes can be used as in the h5p.json license.

The lists of license codes allowed for h5p.json and library.json by H5PValidator differ significantly:

H5PValidator::$h5pOptional

'license' => '/^(CC BY|CC BY-SA|CC BY-ND|CC BY-NC|CC BY-NC-SA|CC BY-NC-ND|CC0 1\.0|GNU GPL|PD|ODC PDDL|CC PDM|U|C)$/'

H5PValidator::$libraryOptional

'license' => '/^(cc-by|cc-by-sa|cc-by-nd|cc-by-nc|cc-by-nc-sa|cc-by-nc-nd|pd|cr|MIT|GPL1|GPL2|GPL3|MPL|MPL2)$/',

If there are historical reasons for the validator to support different codes for the library definition, shouldn't it be a superset (to align with the documentation)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant