Skip to content

Commit c96d1a3

Browse files
authored
Fix issue #4 (use-after-free) in BPMiniGame_SymbolicLogic::FlattenPremise() (#5)
1 parent 9bd3d9a commit c96d1a3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/minigames/symboliclogic.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ void BPMiniGame_SymbolicLogic::Render() {
116116
}
117117
}
118118

119-
const char* BPMiniGame_SymbolicLogic::FlattenPremise(BPMiniGame_SymbolicLogic_Premise* premise) {
119+
std::string BPMiniGame_SymbolicLogic::FlattenPremise(BPMiniGame_SymbolicLogic_Premise* premise) {
120120
ostringstream result;
121121

122122
switch (premise->Type) {
@@ -150,7 +150,7 @@ const char* BPMiniGame_SymbolicLogic::FlattenPremise(BPMiniGame_SymbolicLogic_Pr
150150
break;
151151
}
152152

153-
return result.str().c_str();
153+
return result.str();
154154
}
155155

156156
void BPMiniGame_SymbolicLogic::Tick() {

src/minigames/symboliclogic.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class BPMiniGame_SymbolicLogic : public BPMiniGame {
6767
void Start();
6868
int GetWeight();
6969
void Render();
70-
const char* FlattenPremise(BPMiniGame_SymbolicLogic_Premise* premise);
70+
std::string FlattenPremise(BPMiniGame_SymbolicLogic_Premise* premise);
7171
void Tick();
7272

7373
void OnMouseDown();

0 commit comments

Comments
 (0)