feat: allow users with space in username (#46)

* Allow for spaces in name
* Add tests that account for names with spaces

Closes #44

Author: Patrick B

src/auth.coffee

@@ -66,9 +66,10 @@ module.exports = (robot) ->
   robot.auth = new Auth
 
 
-  robot.respond /@?([^\s]+) ha(?:s|ve) (["'\w: -_]+) role/i, (msg) ->
+  robot.respond /@?(.+) ha(?:s|ve) (["'\w: -_]+) role/i, (msg) ->
     name = msg.match[1].trim()
     if name.toLowerCase() is 'i' then name = msg.message.user.name
+    if name.match(/(.*)(?:don['’]t|doesn['’]t|do not|does not)/i) then return
 
     unless name.toLowerCase() in ['', 'who', 'what', 'where', 'when', 'why']
       unless robot.auth.isAdmin msg.message.user
@@ -90,7 +91,7 @@ module.exports = (robot) ->
             user.roles.push(newRole)
             msg.reply "OK, #{name} has the '#{newRole}' role."
 
-  robot.respond /@?([^\s]+) (?:don['’]t|doesn['’]t|do not) have (["'\w: -_]+) role/i, (msg) ->
+  robot.respond /@?(.+) (?:don['’]t|doesn['’]t|do not|does not) have (["'\w: -_]+) role/i, (msg) ->
     name = msg.match[1].trim()
     if name.toLowerCase() is 'i' then name = msg.message.user.name
 
@@ -111,7 +112,7 @@ module.exports = (robot) ->
           user.roles = (role for role in user.roles when role isnt newRole)
           msg.reply "OK, #{name} doesn't have the '#{newRole}' role."
 
-  robot.respond /what roles? do(es)? @?([^\s]+) have\?*$/i, (msg) ->
+  robot.respond /what roles? do(es)? @?(.+) have\?*$/i, (msg) ->
     name = msg.match[2].trim()
     if name.toLowerCase() is 'i' then name = msg.message.user.name
     user = robot.brain.userForName(name)

test/auth-test.coffee

@@ -17,6 +17,9 @@ describe "auth", ->
     @room.robot.brain.userForId "amy",
       name: "amy"
 
+    @room.robot.brain.userForId "jimmy jones",
+      name: "jimmy jones"
+
   afterEach ->
     @room.destroy()
 
@@ -37,6 +40,13 @@ describe "auth", ->
           ["hubot", "@alice OK, alice has the 'demo' role."]
         ]
 
+    it "admin user successfully sets role for user with space in name", ->
+      @room.user.say("alice", "hubot: jimmy jones has demo role").then =>  
+        expect(@room.messages).to.eql [
+          ["alice", "hubot: jimmy jones has demo role"]
+          ["hubot", "@alice OK, jimmy jones has the 'demo' role."]
+        ]
+
 
     it "fail to add admin role via command", ->
       @room.user.say("alice", "hubot: jimmy has admin role").then =>
@@ -70,6 +80,17 @@ describe "auth", ->
           ["hubot", "@alice Sorry, the 'admin' role can only be removed from the HUBOT_AUTH_ADMIN env variable."]
         ]
 
+
+    it "admin user successfully removes role from user with space", ->
+      @room.user.say("alice", "hubot: jimmy jones has demo role").then =>
+        @room.user.say("alice", "hubot: jimmy jones doesn't have demo role").then =>
+          expect(@room.messages).to.eql [
+            ["alice", "hubot: jimmy jones has demo role"]
+            ["hubot", "@alice OK, jimmy jones has the 'demo' role."]
+            ["alice", "hubot: jimmy jones doesn't have demo role"]
+            ["hubot", "@alice OK, jimmy jones doesn't have the 'demo' role."]
+          ]
+
   context "what roles does <user> have", ->
     beforeEach ->
       @room.user.say("alice", "hubot: alice has demo role")
@@ -99,20 +120,28 @@ describe "auth", ->
         ]
 
   context "list assigned roles", ->
-    beforeEach ->
-        @room.user.say("alice", "hubot: alice has demo role").then =>
-          @room.user.say("alice", "hubot: amy has test role").then =>
-            @room.user.say "alice", "hubot: alice has test role"
-
     it "successfully list assigned roles", ->
-        @room.user.say("alice", "hubot: list assigned roles").then =>
+      @room.user.say("alice", "hubot: alice has demo role").then =>
+        @room.user.say("alice", "hubot: amy has test role").then =>
+          @room.user.say("alice", "hubot: alice has test role").then =>
+            @room.user.say("alice", "hubot: list assigned roles").then =>
+              expect(@room.messages).to.eql [
+                ["alice", "hubot: alice has demo role"]
+                ["hubot", "@alice OK, alice has the 'demo' role."]
+                ["alice", "hubot: amy has test role"]
+                ["hubot", "@alice OK, amy has the 'test' role."]
+                ["alice", "hubot: alice has test role"]
+                ["hubot", "@alice OK, alice has the 'test' role."]
+                ["alice", "hubot: list assigned roles"]
+                ["hubot", "@alice The following roles are available: demo, test"]
+              ]
+
+    it "successfully lists roles of user with space in name", ->
+      @room.user.say("alice", "hubot: jimmy jones has demo role").then =>
+        @room.user.say("amy", "hubot: what roles does jimmy jones have?").then =>
           expect(@room.messages).to.eql [
-            ["alice", "hubot: alice has demo role"]
-            ["hubot", "@alice OK, alice has the 'demo' role."]
-            ["alice", "hubot: amy has test role"]
-            ["hubot", "@alice OK, amy has the 'test' role."]
-            ["alice", "hubot: alice has test role"]
-            ["hubot", "@alice OK, alice has the 'test' role."]
-            ["alice", "hubot: list assigned roles"]
-            ["hubot", "@alice The following roles are available: demo, test"]
-          ]
+            ["alice", "hubot: jimmy jones has demo role"]
+            ["hubot", "@alice OK, jimmy jones has the 'demo' role."]
+            ["amy", "hubot: what roles does jimmy jones have?"]
+            ["hubot", "@amy jimmy jones has the following roles: demo."]
+          ]