RouterMethods.add(middlewareStack:) -> RouterMethods.addMiddleware(mi… (#540)

* RouterMethods.add(middlewareStack:) -> RouterMethods.addMiddleware(middlewareStack:)

* Rename parameter, minor formatting change

* formatting

Author: adam-fowler

Sources/Hummingbird/Configuration.swift

@@ -48,10 +48,10 @@ public struct ApplicationConfiguration: Sendable {
     /// - Parameters:
     ///   - address: Bind address for server
     ///   - serverName: Server name to return in "server" header
-    ///   - backlog: the maximum length for the queue of pending connections.  If a connection request 
+    ///   - backlog: the maximum length for the queue of pending connections.  If a connection request
     ///         arrives with the queue full, the client may receive an error with an indication of ECONNREFUSE
     ///   - reuseAddress: Allows socket to be bound to an address that is already in use.
-    ///   - availableConnectionsDelegate: Object deciding on when we should accept new connection. Use 
+    ///   - availableConnectionsDelegate: Object deciding on when we should accept new connection. Use
     ///         ``HummingbirdCore/MaximumAvailableConnections`` to set the maximum allowed connections.
     public init(
         address: BindAddress = .hostname(),
@@ -77,7 +77,7 @@ public struct ApplicationConfiguration: Sendable {
     ///   - address: Bind address for server
     ///   - serverName: Server name to return in "server" header
     ///   - reuseAddress: Allows socket to be bound to an address that is already in use.
-    ///   - availableConnectionsDelegate: Object deciding on when we should accept new connection. Use 
+    ///   - availableConnectionsDelegate: Object deciding on when we should accept new connection. Use
     ///         ``HummingbirdCore/MaximumAvailableConnections`` to set the maximum allowed connections.
     ///   - tlsOptions: TLS options for when you are using NIOTransportServices
     public init(

Sources/Hummingbird/Router/RouterMethods.swift

@@ -89,7 +89,7 @@ extension RouterMethods {
     /// ``MiddlewareFixedTypeBuilder``.
     ///
     /// ```swift
-    /// router.add {
+    /// router.addMiddleware {
     ///     LogRequestsMiddleware()
     ///     MetricsMiddleware()
     /// }
@@ -98,10 +98,10 @@ extension RouterMethods {
     ///
     /// - Parameter middlewareStack: Middleware stack result builder
     /// - Returns: router
-    @discardableResult public func add(
-        @MiddlewareFixedTypeBuilder<Request, Response, Context> middlewareStack: () -> some MiddlewareProtocol<Request, Response, Context>
+    @discardableResult public func addMiddleware(
+        @MiddlewareFixedTypeBuilder<Request, Response, Context> buildMiddlewareStack: () -> some MiddlewareProtocol<Request, Response, Context>
     ) -> Self {
-        return self.add(middleware: middlewareStack())
+        return self.add(middleware: buildMiddlewareStack())
     }
 
     /// GET path for async closure returning type conforming to ResponseGenerator

Sources/HummingbirdCore/Response/ResponseBody.swift

@@ -62,7 +62,7 @@ public struct ResponseBody: Sendable {
     /// Initialise ResponseBody that contains a sequence of ByteBuffers
     /// - Parameter byteBuffers: Sequence of ByteBuffers to write
     public init<BufferSequence: Sequence & Sendable>(contentsOf byteBuffers: BufferSequence) where BufferSequence.Element == ByteBuffer {
-        self.init(contentLength: byteBuffers.map { $0.readableBytes }.reduce(0, +)) { writer in
+        self.init(contentLength: byteBuffers.map(\.readableBytes).reduce(0, +)) { writer in
             try await writer.write(contentsOf: byteBuffers)
             try await writer.finish(nil)
         }

Tests/HummingbirdTests/MiddlewareTests.swift

@@ -461,7 +461,7 @@ final class MiddlewareTests: XCTestCase {
             }
         }
         let router = Router()
-        router.add {
+        router.addMiddleware {
             TestMiddleware(string: "first")
             TestMiddleware(string: "second")
         }