Remove @escaping from test closure in Application.test(_:_:) (#555)

adam-fowler · web-flow · commit f7f9b9e6a546 · 2024-09-17T23:26:30.000+01:00
diff --git a/Sources/HummingbirdTesting/Application+Test.swift b/Sources/HummingbirdTesting/Application+Test.swift
@@ -76,7 +76,7 @@ extension ApplicationProtocol {
     ///   - test: test function
     public func test<Value>(
         _ testingSetup: TestingSetup,
-        _ test: @escaping @Sendable (any TestClientProtocol) async throws -> Value
+        _ test: @Sendable (any TestClientProtocol) async throws -> Value
     ) async throws -> Value {
         let app: any ApplicationTestFramework = switch testingSetup.value {
         case .router: try await RouterTestFramework(app: self)
diff --git a/Sources/HummingbirdTesting/ApplicationTester.swift b/Sources/HummingbirdTesting/ApplicationTester.swift
@@ -93,5 +93,5 @@ protocol ApplicationTestFramework {
     associatedtype Client: TestClientProtocol
 
     /// Run test server
-    func run<Value>(_ test: @escaping @Sendable (any TestClientProtocol) async throws -> Value) async throws -> Value
+    func run<Value>(_ test: @Sendable (any TestClientProtocol) async throws -> Value) async throws -> Value
 }
diff --git a/Sources/HummingbirdTesting/AsyncHTTPClientTestFramework.swift b/Sources/HummingbirdTesting/AsyncHTTPClientTestFramework.swift
@@ -56,7 +56,7 @@ final class AsyncHTTPClientTestFramework<App: ApplicationProtocol>: ApplicationT
     }
 
     /// Start tests
-    func run<Value>(_ test: @escaping @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {
+    func run<Value>(_ test: @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {
         try await withThrowingTaskGroup(of: Void.self) { group in
             let serviceGroup = ServiceGroup(
                 configuration: .init(
diff --git a/Sources/HummingbirdTesting/LiveTestFramework.swift b/Sources/HummingbirdTesting/LiveTestFramework.swift
@@ -49,7 +49,7 @@ final class LiveTestFramework<App: ApplicationProtocol>: ApplicationTestFramewor
     }
 
     /// Start tests
-    func run<Value>(_ test: @escaping @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {
+    func run<Value>(_ test: @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {
         try await withThrowingTaskGroup(of: Void.self) { group in
             let serviceGroup = ServiceGroup(
                 configuration: .init(
diff --git a/Sources/HummingbirdTesting/RouterTestFramework.swift b/Sources/HummingbirdTesting/RouterTestFramework.swift
@@ -48,7 +48,7 @@ struct RouterTestFramework<Responder: HTTPResponder>: ApplicationTestFramework w
     }
 
     /// Run test
-    func run<Value>(_ test: @escaping @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {
+    func run<Value>(_ test: @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {
         let client = Client(
             responder: self.responder,
             logger: self.logger,

Original file line number	Diff line number	Diff line change
`@@ -93,5 +93,5 @@ protocol ApplicationTestFramework {`
`93`	`93`	`associatedtype Client: TestClientProtocol`
`94`	`94`
`95`	`95`	`/// Run test server`
`96`		`- func run<Value>(_ test: @escaping @Sendable (any TestClientProtocol) async throws -> Value) async throws -> Value`
	`96`	`+ func run<Value>(_ test: @Sendable (any TestClientProtocol) async throws -> Value) async throws -> Value`
`97`	`97`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ final class AsyncHTTPClientTestFramework<App: ApplicationProtocol>: ApplicationT`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`/// Start tests`
`59`		`- func run<Value>(_ test: @escaping @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {`
	`59`	`+ func run<Value>(_ test: @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {`
`60`	`60`	`try await withThrowingTaskGroup(of: Void.self) { group in`
`61`	`61`	`let serviceGroup = ServiceGroup(`
`62`	`62`	`configuration: .init(`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ final class LiveTestFramework<App: ApplicationProtocol>: ApplicationTestFramewor`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`/// Start tests`
`52`		`- func run<Value>(_ test: @escaping @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {`
	`52`	`+ func run<Value>(_ test: @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {`
`53`	`53`	`try await withThrowingTaskGroup(of: Void.self) { group in`
`54`	`54`	`let serviceGroup = ServiceGroup(`
`55`	`55`	`configuration: .init(`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ struct RouterTestFramework<Responder: HTTPResponder>: ApplicationTestFramework w`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`/// Run test`
`51`		`- func run<Value>(_ test: @escaping @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {`
	`51`	`+ func run<Value>(_ test: @Sendable (TestClientProtocol) async throws -> Value) async throws -> Value {`
`52`	`52`	`let client = Client(`
`53`	`53`	`responder: self.responder,`
`54`	`54`	`logger: self.logger,`