Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTHENTICATION_METHOD is deprecated as of allauth v65.4 #679

Open
browniebroke opened this issue Feb 12, 2025 · 3 comments · May be fixed by #681
Open

AUTHENTICATION_METHOD is deprecated as of allauth v65.4 #679

browniebroke opened this issue Feb 12, 2025 · 3 comments · May be fixed by #681

Comments

@browniebroke
Copy link

browniebroke commented Feb 12, 2025 •
edited
Loading

Django-allauth deprecated their AUTHENTICATION_METHOD in version 65.4 and replaced it with a new setting:

To make way for a future "phone" method, AUTHENTICATION_METHOD was removed in favor of a new LOGIN_METHODS.

https://docs.allauth.org/en/latest/release-notes/recent.html#id1

I noticed that I still had some warnings being logged while running tests in my project and it seems that they come from usages in dj-rest-auth
@browniebroke browniebroke changed the title Handle allauth v65.4 deprecation of AUTHENTICATION_METHOD AUTHENTICATION_METHOD is deprecated as of allauth v65.4 Feb 12, 2025
@browniebroke
Copy link
Author

I started to look at how to handle this and was wondering what option to take:

  1. support both AUTHENTICATION_METHOD and LOGIN_METHODS settings, leaving the minimum required allauth version as is
  2. support LOGIN_METHODS only (drop support for AUTHENTICATION_METHOD) and bump the minimum version of allauth to >= 65.4

browniebroke added a commit to browniebroke/dj-rest-auth that referenced this issue Feb 24, 2025
@browniebroke
feat: add compatibility with django-allauth v65.4
59b8cab 
Fix iMerica#679
@browniebroke browniebroke linked a pull request Feb 24, 2025 that will close this issue
Open
@ratmat2002
Copy link

Any progress on this? I think Option 1 would be best.

-- Update the base dj-rest-auth backage to use LOGIN_METHODS by default.
-- Support user provided overrides to AUTHENTICATION_METHOD but inform about the all_auth warnings.
-- User provided LOGIN_METHODS fully supported without warnings.

@browniebroke
Copy link
Author

I've opened a pull request with option 1: #681

@browniebroke browniebroke mentioned this issue Mar 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add compatibility with django-allauth v65.4 browniebroke/dj-rest-auth
2 participants
@browniebroke @ratmat2002