Skip to content

Commit 8c50b0e

Browse files
committedOct 22, 2024·
[PHPStan] Aligned baseline with PHPStan update
1 parent 4bde741 commit 8c50b0e

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed
 

‎phpstan-baseline.neon

+10-5
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,16 @@ parameters:
420420
count: 1
421421
path: src/bundle/Core/Command/UpdateTimestampsToUTCCommand.php
422422

423+
-
424+
message: "#^Cannot cast Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string to int\\.$#"
425+
count: 1
426+
path: src/bundle/Core/Command/VirtualFieldDuplicateFixCommand.php
427+
428+
-
429+
message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\Command\\\\VirtualFieldDuplicateFixCommand\\:\\:getDuplicatedAttributesBatch\\(\\) should return array\\<array\\{version\\: int, contentclassattribute_id\\: int, contentobject_id\\: int, language_id\\: int\\}\\> but returns array\\<int, array\\<string, mixed\\>\\>\\.$#"
430+
count: 1
431+
path: src/bundle/Core/Command/VirtualFieldDuplicateFixCommand.php
432+
423433
-
424434
message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\Converter\\\\ContentParamConverter\\:\\:getSupportedClass\\(\\) has no return type specified\\.$#"
425435
count: 1
@@ -10885,11 +10895,6 @@ parameters:
1088510895
count: 1
1088610896
path: src/lib/IO/IOMetadataHandler/LegacyDFSCluster.php
1088710897

10888-
-
10889-
message: "#^Cannot call method rowCount\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
10890-
count: 3
10891-
path: src/lib/IO/IOMetadataHandler/LegacyDFSCluster.php
10892-
1089310898
-
1089410899
message: "#^Method Ibexa\\\\Core\\\\IO\\\\IOMetadataHandler\\\\LegacyDFSCluster\\:\\:delete\\(\\) has no return type specified\\.$#"
1089510900
count: 1

‎phpstan.neon.dist

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ parameters:
99
treatPhpDocTypesAsCertain: false
1010
ignoreErrors:
1111
-
12-
message: "#^Cannot call method (fetchOne|fetchColumn|fetchAllAssociative|fetchAssociative|fetchAllKeyValue|fetchFirstColumn)\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
12+
message: "#^Cannot call method (fetchOne|fetchColumn|fetchAllAssociative|fetchAssociative|fetchAllKeyValue|fetchFirstColumn|rowCount)\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
1313
paths:
1414
- src/*
1515
- tests/*

‎src/bundle/Core/Command/VirtualFieldDuplicateFixCommand.php

+8-3
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ private function getDuplicatedAttributeTotalCount(
164164
->from('ezcontentobject_attribute', 'a')
165165
->having('instances > 1');
166166

167-
$count = $query->execute()->rowCount();
167+
$count = (int) $query->execute()->rowCount();
168168

169169
if ($count > 0) {
170170
$style->warning(
@@ -245,13 +245,18 @@ private function askForConfirmation(SymfonyStyle $style): bool
245245
);
246246
}
247247

248-
private function deleteAttributes($ids): int
248+
/**
249+
* @param int[] $ids
250+
*
251+
* @throws \Doctrine\DBAL\Exception
252+
*/
253+
private function deleteAttributes(array $ids): int
249254
{
250255
$query = $this->connection->createQueryBuilder();
251256

252257
$query
253258
->delete('ezcontentobject_attribute')
254-
->andWhere($query->expr()->in('id', $ids));
259+
->andWhere($query->expr()->in('id', array_map('strval', $ids)));
255260

256261
return (int)$query->execute();
257262
}

0 commit comments

Comments
 (0)