Skip to content

Commit 2335e15

Browse files
committed
Update document
1 parent bb16aa7 commit 2335e15

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

docs/reference.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ API Reference
44
Launcher
55
--------
66

7-
.. autoclass:: pyppeteer.launcher.Launcher
8-
:members:
7+
.. autofunction:: pyppeteer.launcher.launch
8+
.. autofunction:: pyppeteer.launcher.connect
99

1010
Browser
1111
-------

docs/server.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
docsdir = path.dirname(path.abspath(__file__))
1010
builddir = path.join(docsdir, '_build')
1111
build_cmd = [
12-
'sphinx-build', '-b', 'html', '-E', '-q',
12+
'sphinx-build', '-b', 'html', '-E', '-q', '-j', '4',
1313
'-d', path.join(builddir, 'doctrees'),
1414
docsdir, path.join(builddir, 'html'),
1515
]

pyppeteer/launcher.py

+11-7
Original file line numberDiff line numberDiff line change
@@ -104,17 +104,21 @@ def killChrome(self) -> None:
104104
self.proc.wait()
105105
logger.debug('done.')
106106

107-
# async def connect(self, browserWSEndpoint: str,
108-
# ignoreHTTPSErrors: bool = False) -> Browser:
109-
# connection = await Connection.create(browserWSEndpoint)
110-
# return Browser(connection, bool(ignoreHTTPSErrors), self.killChrome)
107+
async def connect(self, browserWSEndpoint: str,
108+
ignoreHTTPSErrors: bool = False) -> Browser:
109+
"""Not Implemented."""
110+
raise NotImplementedError('NotImplemented')
111+
# connection = await Connection.create(browserWSEndpoint)
112+
# return Browser(connection, bool(ignoreHTTPSErrors), self.killChrome)
111113

112114

113115
def launch(options: dict = None) -> Browser:
114116
"""Start chromium process and return `Browser` object."""
115117
return Launcher(options).launch()
116118

117119

118-
# def connect(options: dict = None) -> Browser:
119-
# l = Launcher(options)
120-
# return l.connect()
120+
def connect(options: dict = None) -> Browser:
121+
"""Not Implemented."""
122+
raise NotImplementedError('NotImplemented')
123+
# l = Launcher(options)
124+
# return l.connect()

0 commit comments

Comments
 (0)