-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
number of observed animals (count individuals) #41
Comments
I would call this function |
can this issue be closed ? @damianooldoni |
I would prefer to leave it open as you mentioned in this issue a second requirement:
So, I was thinking to tackle this after tackling the filtering by age and sex for RAI as well (see inbo/camtrapdp#42 (comment)) |
Meanwhile, the more reasonable way to add the option of calculating RAI based on n_obs (via get_rai(datapkg, species, by) # allowed values of by arg: one of "n_obs", "n_individuals" @jimcasaer: should this new arg have a default value? In other words, do you use RAI more often by using the number of observations or the number of individuals or it's 50%-50%? |
why don't you cal it 'feature' as was done in the map_dep() ? |
That's also a good idea, @jimcasaer. No, it's not so difficult to add this, no worries, just that it's good practice to wait 5 minutes about thinking about a good name than changing it afterwards as it is annoying for the users as they have to unlearn something. @peterdesmet: what do you think? get_rai(..., feature = "n_obs") # other possible value: "n_individuals" I agree with @jimcasaer and I would prefer |
Don't know the context, but |
One problem found just now: if we use map_dep(camtrapdp, feature = "rai", ...) # how to pass feature = "n_individuals" to get_rai()??? We should avoid to reuse # one option
get_rai(..., n = "n_obs") #where is the common part between n_obs and n_individuals
# other option
get_rai(..., n_obs = TRUE, n_individuals = FALSE) # two args which if both TRUE or FALSE n_obs is used and warning returned we should also find a good name to use in |
The nights whispered a wise and simple solution: just splitting it in two functions, |
I like the night :-) |
create a function to calculate the number of observed animals in a deployment (get_count() ?) or for a specific time interval (see #38)
rai could also be based on the number of observed animals rather than the number of observations (allow selection? )
The text was updated successfully, but these errors were encountered: