Merge pull request #1 from lafrenierejm/branch-protection-drift

feat: Reduce number of iterations over `actors`

Author: RoseSecurity

github/util_v4_branch_protection.go

@@ -475,6 +475,10 @@ func setPushActorIDs(actors []PushActorTypes, data BranchProtectionResourceData,
 			id = a.Actor.User.ID.(string)
 		} else if a.Actor.App.ID != nil {
 			id = a.Actor.App.ID.(string)
+		} else if a.Actor.Team.Slug != "" {
+			formattedID = orgName + "/" + string(a.Actor.Team.Slug)
+		} else if a.Actor.User.Login != "" {
+			formattedID = "/" + string(a.Actor.User.Login)
 		}
 
 		if id != "" {
@@ -485,26 +489,6 @@ func setPushActorIDs(actors []PushActorTypes, data BranchProtectionResourceData,
 		}
 	}
 
-	for _, a := range actors {
-		if a.Actor.Team.ID == nil && a.Actor.User.ID == nil && a.Actor.App.ID == nil {
-			var formattedID string
-			if a.Actor.Team.Slug != "" {
-				formattedID = orgName + "/" + string(a.Actor.Team.Slug)
-			} else if a.Actor.User.Login != "" {
-				formattedID = "/" + string(a.Actor.User.Login)
-			} else if a.Actor.App != (Actor{}) {
-				continue
-			}
-
-			if formattedID != "" {
-				if _, exists := seenIDs[formattedID]; !exists {
-					pushActors = append(pushActors, formattedID)
-					seenIDs[formattedID] = struct{}{}
-				}
-			}
-		}
-	}
-
 	// Sort for consistent ordering
 	sort.Strings(pushActors)