fix(github_actions_repository_oidc_subject_claim_customization_template): graceful handling of 404 on read (#2483)

acouvreur · kfcampbell · web-flow · commit d63ad7812a3c · 2025-02-27T15:41:46.000-08:00
The resource github_actions_repository_oidc_subject_claim_customization_template would error when the associated repository was deleted.

This change will gracefully remove the resource on 404 not found.

Co-authored-by: Keegan Campbell &lt;me@kfcampbell.com&gt;
diff --git a/github/resource_github_actions_repository_oidc_subject_claim_customization_template.go b/github/resource_github_actions_repository_oidc_subject_claim_customization_template.go
@@ -95,7 +95,7 @@ func resourceGithubActionsRepositoryOIDCSubjectClaimCustomizationTemplateRead(d
 	template, _, err := client.Actions.GetRepoOIDCSubjectClaimCustomTemplate(ctx, owner, repository)
 
 	if err != nil {
-		return err
+		return deleteResourceOn404AndSwallow304OtherwiseReturnError(err, d, "actions repository oidc subject claim customization template (%s, %s)", owner, repository)
 	}
 
 	if err = d.Set("repository", repository); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ func resourceGithubActionsRepositoryOIDCSubjectClaimCustomizationTemplateRead(d`
`95`	`95`	`template, _, err := client.Actions.GetRepoOIDCSubjectClaimCustomTemplate(ctx, owner, repository)`
`96`	`96`
`97`	`97`	`if err != nil {`
`98`		`- return err`
	`98`	`+ return deleteResourceOn404AndSwallow304OtherwiseReturnError(err, d, "actions repository oidc subject claim customization template (%s, %s)", owner, repository)`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`if err = d.Set("repository", repository); err != nil {`