Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Rename GITHUB_APP_PEM_FILE to GITHUB_APP_PRIVATE_KEY for consistency with GitHub terminology #2577

Open
1 task done
jamesgeddes opened this issue Mar 1, 2025 · 0 comments
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request

Comments

@jamesgeddes
Copy link

jamesgeddes commented Mar 1, 2025

Describe the need

On the GitHub App configuration page (https://github.com/organizations/[owner]/settings/apps/[app name]) and throughout GitHub’s official documentation, the .pem file that a GitHub app provides is referred to as a "private key". The GitHub Terraform provider, however, currently uses the variable name GITHUB_APP_PEM_FILE instead of GITHUB_APP_PRIVATE_KEY.

While functionally equivalent, this inconsistency makes knowledge transfer more difficult because:

  1. Users must manually confirm that GITHUB_APP_PEM_FILE refers to the private key rather than another GitHub App credential.
  2. Other GitHub tools, such as GitHub Actions (actions/create-github-app-token), use private-key, leading to unnecessary confusion.
  3. Using GitHub’s native terminology improves clarity and reduces onboarding friction.

Proposal

  • Introduce GITHUB_APP_PRIVATE_KEY as the preferred variable name.
  • Continue supporting GITHUB_APP_PEM_FILE as a deprecated alias for backward compatibility.

This change would ensure consistency across GitHub’s ecosystem while maintaining existing behavior for current users.

Could this improvement be considered?

SDK Version

No response

API Version

No response

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jamesgeddes jamesgeddes added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Mar 1, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant