chore(tests): fix remaining tests

Author: JordanGoasdoue

Makefile

@@ -133,7 +133,7 @@ importfmt: get-fmt-deps ## Checks the import format of the Go source files
 fmt: importfmt
 	@echo "FORMATTING SOURCE"
 	FORMATTED=`$(GO) fmt ./...`
-	@([[ ! -z "$(FORMATTED)" ]] && printf "Fixed un-formatted files:\n$(FORMATTED)") || true
+	@([ ! -z "$(FORMATTED)" ] && printf "Fixed un-formatted files:\n$(FORMATTED)") || true
 
 GOLINT := $(GOPATH)/bin/golint
 $(GOLINT):

go.mod

@@ -25,9 +25,10 @@ require (
 	github.com/tektoncd/pipeline v0.65.3
 	golang.org/x/oauth2 v0.23.0
 	gopkg.in/robfig/cron.v2 v2.0.0-20150107220207-be2e0b0deed5
-	k8s.io/api v0.32.1
+	k8s.io/api v0.32.3
+	k8s.io/apiextensions-apiserver v0.32.3 // indirect
 	k8s.io/apimachinery v0.32.3
-	k8s.io/client-go v0.32.1
+	k8s.io/client-go v0.32.3
 	k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738
 	knative.dev/pkg v0.0.0-20240416145024-0f34a8815650
 	sigs.k8s.io/controller-runtime v0.20.3
@@ -111,7 +112,6 @@ require (
 	gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
-	k8s.io/apiextensions-apiserver v0.32.1 // indirect
 	k8s.io/klog/v2 v2.130.1 // indirect
 	k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f // indirect
 	sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
@@ -128,8 +128,6 @@ replace (
 
 	// gomodules.xyz breaks in Athens proxying
 	gomodules.xyz/jsonpatch/v2 => github.com/gomodules/jsonpatch/v2 v2.2.0
-	k8s.io/api => k8s.io/api v0.32.3
-	k8s.io/apimachinery => k8s.io/apimachinery v0.32.3
 )
 
 go 1.23.0

go.sum

@@ -755,12 +755,12 @@ honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9
 honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
 k8s.io/api v0.32.3 h1:Hw7KqxRusq+6QSplE3NYG4MBxZw1BZnq4aP4cJVINls=
 k8s.io/api v0.32.3/go.mod h1:2wEDTXADtm/HA7CCMD8D8bK4yuBUptzaRhYcYEEYA3k=
-k8s.io/apiextensions-apiserver v0.32.1 h1:hjkALhRUeCariC8DiVmb5jj0VjIc1N0DREP32+6UXZw=
-k8s.io/apiextensions-apiserver v0.32.1/go.mod h1:sxWIGuGiYov7Io1fAS2X06NjMIk5CbRHc2StSmbaQto=
+k8s.io/apiextensions-apiserver v0.32.3 h1:4D8vy+9GWerlErCwVIbcQjsWunF9SUGNu7O7hiQTyPY=
+k8s.io/apiextensions-apiserver v0.32.3/go.mod h1:8YwcvVRMVzw0r1Stc7XfGAzB/SIVLunqApySV5V7Dss=
 k8s.io/apimachinery v0.32.3 h1:JmDuDarhDmA/Li7j3aPrwhpNBA94Nvk5zLeOge9HH1U=
 k8s.io/apimachinery v0.32.3/go.mod h1:GpHVgxoKlTxClKcteaeuF1Ul/lDVb74KpZcxcmLDElE=
-k8s.io/client-go v0.32.1 h1:otM0AxdhdBIaQh7l1Q0jQpmo7WOFIk5FFa4bg6YMdUU=
-k8s.io/client-go v0.32.1/go.mod h1:aTTKZY7MdxUaJ/KiUs8D+GssR9zJZi77ZqtzcGXIiDg=
+k8s.io/client-go v0.32.3 h1:RKPVltzopkSgHS7aS98QdscAgtgah/+zmpAogooIqVU=
+k8s.io/client-go v0.32.3/go.mod h1:3v0+3k4IcT9bXTc4V2rt+d2ZPPG700Xy6Oi0Gdl2PaY=
 k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=
 k8s.io/klog/v2 v2.130.1/go.mod h1:3Jpz1GvMt720eyJH1ckRHK1EDfpxISzJ7I9OYgaDtPE=
 k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f h1:GA7//TjRY9yWGy1poLzYYJJ4JRdzg3+O6e8I+e+8T5Y=

pkg/apis/lighthouse/v1alpha1/breakpoint_test.go

@@ -22,7 +22,9 @@ func TestBreakpointResolveDebug(t *testing.T) {
 					Task:       "sometask",
 				},
 				Debug: pipelinev1.TaskRunDebug{
-					Breakpoint: []string{"onFailure"},
+					Breakpoints: &pipelinev1.TaskBreakpoints{
+						OnFailure: "onFailure",
+					},
 				},
 			},
 		},
@@ -32,7 +34,9 @@ func TestBreakpointResolveDebug(t *testing.T) {
 					Task: "special-task",
 				},
 				Debug: pipelinev1.TaskRunDebug{
-					Breakpoint: []string{"something"},
+					Breakpoints: &pipelinev1.TaskBreakpoints{
+						OnFailure: "something",
+					},
 				},
 			},
 		},
@@ -54,7 +58,9 @@ func TestBreakpointResolveDebug(t *testing.T) {
 				Task:       "sometask",
 			},
 			expected: &pipelinev1.TaskRunDebug{
-				Breakpoint: []string{"onFailure"},
+				Breakpoints: &pipelinev1.TaskBreakpoints{
+					OnFailure: "onFailure",
+				},
 			},
 		},
 		{
@@ -91,7 +97,7 @@ func TestBreakpointResolveDebug(t *testing.T) {
 			},
 			expected: &pipelinev1.TaskRunDebug{
 				Breakpoints: &pipelinev1.TaskBreakpoints{
-					BeforeSteps: []string{"something"},
+					OnFailure: "something",
 				},
 			},
 		},

pkg/keeper/pipelinerun_monitor_test.go

@@ -186,7 +186,9 @@ func makeTestPipelineRun(condition *kpgapis.Condition, baseRunName string, pipel
 				APIVersion: tektonAPIVersion,
 				Name:       pipelineName,
 			},
-			ServiceAccountName: sa,
+			TaskRunTemplate: pipelinev1.PipelineTaskRunTemplate{
+				ServiceAccountName: sa,
+			},
 		},
 		Status: pipelinev1.PipelineRunStatus{},
 	}

pkg/plugins/updateconfig/updateconfig.go

@@ -119,7 +119,7 @@ func Update(fg FileGetter, kc corev1.ConfigMapInterface, name, namespace string,
 		return fmt.Errorf("failed to fetch current state of configmap: %v", getErr)
 	}
 
-	if cm == nil {
+	if cm == nil || isNotFound {
 		cm = &coreapi.ConfigMap{
 			ObjectMeta: metav1.ObjectMeta{
 				Name:      name,
@@ -149,7 +149,7 @@ func Update(fg FileGetter, kc corev1.ConfigMapInterface, name, namespace string,
 		logger.WithFields(logrus.Fields{"key": upd.Key, "cmName": upd.Filename}).Debug("Populating key.")
 		value := content
 		if upd.GZIP {
-			buff := bytes.NewBuffer([]byte{})
+			buff := new(bytes.Buffer)
 			// TODO: this error is wildly unlikely for anything that
 			// would actually fit in a configmap, we could just as well return
 			// the error instead of falling back to the raw content