Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request template added #153

Merged
merged 1 commit into from
Feb 23, 2025
Merged

pull request template added #153

merged 1 commit into from
Feb 23, 2025

Conversation

hxrshxz
Copy link
Contributor

@hxrshxz hxrshxz commented Feb 21, 2025

Signed-off-by: Harsh Kumar <[email protected]>
@bkimminich bkimminich merged commit 066c4cd into juice-shop:master Feb 23, 2025
1 check passed
@bkimminich
Copy link
Member

This and both the PRs for fixing the link and images should probably have just gone into a single PR for documentation fixes/harmonization - three PRs, two issues, with screenshots/-casts seems to be slight overkill.

@hxrshxz
Copy link
Contributor Author

hxrshxz commented Feb 23, 2025

This and both the PRs for fixing the link and images should probably have just gone into a single PR for documentation fixes/harmonization - three PRs, two issues, with screenshots/-casts seems to be slight overkill.

Noted 👍 will keep this in mind for future pull requests and issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants