Skip to content

Commit 7bf4136

Browse files
SteveL-MSFTSteveL-MSFT
authored
Merge pull request PowerShell#210 from joeyaiello/RFCNotes
Add first set of Committee meeting notes
2 parents b4fc60d + 5888839 commit 7bf4136

6 files changed

+171
-0
lines changed

‎notes/20190610 - RFC Discussion Notes.md

+44
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
# RFC Meeting - June 10, 2019
2+
3+
## Attendees
4+
5+
* Steve Lee
6+
* Dongbo Wang
7+
* Joey Aiello
8+
9+
## Action Items
10+
11+
* Joey: ping @charub
12+
* Joey: write committee member RFC
13+
* Steve: re-rev PowerShellGet 3 RFC
14+
* Steve: PR for experimental features
15+
16+
## Notes
17+
18+
* Experimental Features
19+
* Agreement to take the following out of experimental due to low risk and interactivity:
20+
* Temp drive
21+
* Abbreviation expansion
22+
* Will wait for feedback to see if this should be configurable to "off"
23+
* Will wait on Cloud Shell -> Exchange Online usage to take implicit remoting batching out of experimental
24+
* Check to see if they enable it already today
25+
* Will wait on "Telemetry 2.0" before we make general decision on how to take features out of experimental
26+
* Fuzzy matching suggestion on CommandNotFound should be blocked on suggestion framework fixes
27+
* suggestions are batched to the end of a script
28+
* not shown in VS Code
29+
* Outside Committee members
30+
* AI Joey: Need to write an RFC on process for accepting outside committee members
31+
* Nomination will be fuzzy (based on very holistic criteria)
32+
* Needs formalized requirements on how they get accepted
33+
* Requirements to stay on should be defined
34+
* Apache +0/-0 system
35+
* Requirements should maybe be loose initially just to get moving
36+
* Definitely need to standard for removing people based on non-participation criteria (e.g. code of conduct)
37+
* Should start small (probably with one, maybe two people)
38+
* Geographic tradeoff: domestic is good for calls, international would push asynchronicity
39+
* Start by looking at Apache Foundation and Debian to see their process
40+
* Reviewed and commented on Test-Connection (#172)
41+
* Agreed to use label "Review - Committee" for RFCs that have been partially reviewed/discussed
42+
and may be waiting on additional review
43+
* Need to close on PowerShell 6 specific module path (#133) once we have quorum
44+
* @charub is back, we need to close with her on whether Environment Variable (#92) code exists

‎notes/20190624 - RFC Discussion Notes.md

+38
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# RFC Meeting - June 24, 2019
2+
3+
## Attendees
4+
5+
No quorum today...
6+
7+
* Jim Truher
8+
* Dongbo Wang
9+
* Joey Aiello
10+
11+
## Notes
12+
13+
* PSGet 3.0 RFC has been updated, need to review with Steve when he's back
14+
* Closed PR #138 on the basis that it misunderstood the current process
15+
* Cursorily reviewed and briefly discussed PR 202 for side-by-side `pwsh` support
16+
* Initial reaction is that this is explicitly a non-goal
17+
* We are primarily trying to follow a fix-forward approach to `pwsh`
18+
* Complexity of managing multiple namespaces in package managers is very high
19+
* Also discouraged by distros
20+
* Process on aging PRs out?
21+
* `Waiting on Author` for some period of time?
22+
* Open question: do we give it a number and reject it, or do we just close the PR?
23+
* The former provides more visibility to others who may want to pick it up
24+
* PR after would move it to 2-Draft-Accepted with the existing number
25+
* Probably won't use automation to remove `Waiting on Author`
26+
* Only the author's response would change it
27+
* Still haven't codified the way that experimental features reduce the burden to RFCs
28+
* Jim: "code speaks louder than words"
29+
* Jim did ulimit/umask implementation before he submitted the PR
30+
* At a bare minimum, input/output examples are necessary
31+
* Dongbo: "if you're really going to implement it, you need to think about all the details up front"
32+
* We don't want to think of the implementation plan, but having a design is critical
33+
* One great example is Test-Connection changes (#172)
34+
* Only 121 lines, and it gives everything you need to know about input, output, parameter sets, etc.
35+
* We may need to be more direct about possible breakage that RFCs cause
36+
* Reviewed login shell RFC (PR #186)
37+
* Pending performance measurements of Rob's new method, we will take his method of `pwsh -l` / `pwsh -LoginShell` instead of using `pwsh-login`
38+
* Open question: on a container, does Docker implicitly start the pwsh entrypoint from sh?

‎notes/20190626 - Committee Discussion Notes.md

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# PowerShell Committee Notes - June 26, 2019
2+
3+
## Attendees
4+
5+
* Jim Truher
6+
* Dongbo Wang
7+
* Joey Aiello
8+
* Kenneth Hansen
9+
* Bruce Payette
10+
11+
## Agenda
12+
13+
* Review labeled PowerShell issues
14+
* Review Monday's RFC notes
15+
* Review labeled RFC issues if we have time
16+
17+
## Notes
18+
19+
* Long discussion on modules refactoring/modularizing, and the amount of work involved

‎notes/20190701 - RFC Discussion Notes.md

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# RFC Meeting - July 1, 2019
2+
3+
## Attendees
4+
5+
* Steve Lee
6+
* Dongbo Wang
7+
* Jim Truher
8+
* Joey Aiello
9+
10+
## Notes
11+
12+
* Spoke to Charu, and she believes she has an implementation of Get/Set-EnvironmentVariable to share
13+
* Review `Out-GridView` RFC
14+
* Meta-question: do we need to review this module if it's only shipping in the Gallery?
15+
* RFC acceptance is not blocking publishing to the Gallery
16+
* Jim: "given our existing backlog, we should not spend too much time on RFCs that don't ship production code directly into PowerShell"
17+
* On its face, we don't see a problem publishing the module as written to the Gallery, but we don't
18+
believe Avalonia can ever be shipped as part of PowerShell.
19+
* Reviewed and merged `Test-Connection` RFC0037 (PR #172)
20+
* Reviewed #167 regarding `-Culture` and `-Comparison` parameters on `Select-String`
21+
* Shouldn't be too complicated: the discussion is difficult enough for us, much less for an IT admin
22+
* If you really want full functionality of comparers, it's fine to use C# APIs
23+
* Ultimately accepted Ilya's updated proposal 2 for its conformance to PowerShell's default case-insensitivity

‎notes/20190703 - Committee Discussion Notes.md

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# PowerShell Committee Notes - July 3, 2019
2+
3+
## Attendees
4+
5+
* Steve Lee
6+
* Jim Truher
7+
* Dongbo Wang
8+
* Joey Aiello
9+
* Kenneth Hansen
10+
11+
## Notes
12+
13+
* Fix New-Item -Path/-Target with wildcard char #9259
14+
* No attached issue for discussion
15+
* Issue is that tab completion uses single quotes and escaped chars in what amounts to a literal path
16+
* Agreed not to fix it in the `New-Item` behavior, but we should fix it in the tab completion
17+
* OneDrive mode for offline vs. online files #9895
18+
* OneDrive uses "surrogate reparse points" for its files
19+
* Disagreement around whether PS should report the filesystem as-is reported by the API vs. what the shell tells users in the File Explorer
20+
* PS already matches `cmd` by reporting `Length` with parens for non-cached files
21+
* Agreed to leave files as reporting `l` in the mode
22+
* Jim was concerned .NET Core not making their Win32 wrapper API public
23+
* Might make sense to add a property for surrogate reparse points to make the info scriptable

‎notes/20190708 - RFC Discussion Notes.md

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# RFC Meeting - July 8, 2019
2+
3+
## Attendees
4+
5+
* Steve Lee
6+
* Jim Truher
7+
* Joey Aiello
8+
9+
## Notes
10+
11+
* Review improvement of argument generation for native executables #90
12+
* AI next meeting: get quorum decision
13+
* okay implementing behind experimental feature
14+
* Environment variable cmdlets #92
15+
* Charu has the code, Jim wants to give it a look
16+
* Reviewed HTML cmdlets #137
17+
* Inspired meta conversation on when/how we take modules into PS Core
18+
* Jim: "we need a 'feeder' system that allows folks to incubate modules on the Gallery"
19+
* We need to publish a blog that gives our position on this
20+
* AngleSharp *seems* like the best option, but we should really see an implementation
21+
* Reviewed policy RFC #180
22+
* Jim had a couple concerns
23+
* Window of opportunity as PowerShell starts where they could execute code before machine takes precedence
24+
* User can use reflection to change object model built after policy has been applied

0 commit comments

Comments
 (0)