fix NSAccessibility frame calculation for STTextView

krzyzanowskim · krzyzanowskim · commit 78c612ce519f · 2025-03-13T23:01:50.000+01:00
The fix ensures that accessibilityFrame(for:) returns coordinates in screen space
by properly converting the text segment frame through the view hierarchy to screen
coordinates.
diff --git a/Sources/STTextViewAppKit/STTextView+NSAccessibilityProtocol.swift b/Sources/STTextViewAppKit/STTextView+NSAccessibilityProtocol.swift
@@ -83,10 +83,12 @@ extension STTextView  {
     // NSAccessibilityNavigableStaticText
 
     open override func accessibilityFrame(for range: NSRange) -> NSRect {
-        guard let textRange = NSTextRange(range, in: textContentManager) else {
+        guard let textRange = NSTextRange(range, in: textContentManager),
+              let segmentFrame = textLayoutManager.textSegmentFrame(in: textRange, type: .standard)
+        else {
             return .zero
         }
-        return textLayoutManager.textSegmentFrame(in: textRange, type: .standard) ?? .zero
+        return window?.convertToScreen(contentView.convert(segmentFrame, to: nil)) ?? .zero
     }
 
     open override func accessibilityLine(for index: Int) -> Int {

Original file line number	Diff line number	Diff line change
`@@ -83,10 +83,12 @@ extension STTextView {`
`83`	`83`	`// NSAccessibilityNavigableStaticText`
`84`	`84`
`85`	`85`	`open override func accessibilityFrame(for range: NSRange) -> NSRect {`
`86`		`- guard let textRange = NSTextRange(range, in: textContentManager) else {`
	`86`	`+ guard let textRange = NSTextRange(range, in: textContentManager),`
	`87`	`+ let segmentFrame = textLayoutManager.textSegmentFrame(in: textRange, type: .standard)`
	`88`	`+ else {`
`87`	`89`	`return .zero`
`88`	`90`	`}`
`89`		`- return textLayoutManager.textSegmentFrame(in: textRange, type: .standard) ?? .zero`
	`91`	`+ return window?.convertToScreen(contentView.convert(segmentFrame, to: nil)) ?? .zero`
`90`	`92`	`}`
`91`	`93`
`92`	`94`	`open override func accessibilityLine(for index: Int) -> Int {`