Fix precondition failure in addAttributes(_:range:updateLayout:)

krzyzanowskim · krzyzanowskim · commit d30b176bced4 · 2025-02-01T22:48:31.000+01:00
Replace preconditionFailure with assertionFailure and return early when
encountering an invalid range in addAttributes(_:range:updateLayout:). This
avoids crashing in release builds if an invalid range is passed.
diff --git a/Sources/STTextViewAppKit/STTextView.swift b/Sources/STTextViewAppKit/STTextView.swift
@@ -869,7 +869,8 @@ import AVFoundation
     /// Add attribute. Need `needsViewportLayout = true` to reflect changes.
     private func addAttributes(_ attrs: [NSAttributedString.Key: Any], range: NSRange, updateLayout: Bool) {
         guard let textRange = NSTextRange(range, in: textContentManager) else {
-            preconditionFailure("Invalid range \(range)")
+            assertionFailure("Invalid range \(range)")
+            return
         }
 
         addAttributes(attrs, range: textRange, updateLayout: updateLayout)

Original file line number	Diff line number	Diff line change
`@@ -869,7 +869,8 @@ import AVFoundation`
`869`	`869`	/// Add attribute. Need `needsViewportLayout = true` to reflect changes.
`870`	`870`	`private func addAttributes(_ attrs: [NSAttributedString.Key: Any], range: NSRange, updateLayout: Bool) {`
`871`	`871`	`guard let textRange = NSTextRange(range, in: textContentManager) else {`
`872`		`- preconditionFailure("Invalid range \(range)")`
	`872`	`+ assertionFailure("Invalid range \(range)")`
	`873`	`+ return`
`873`	`874`	`}`
`874`	`875`
`875`	`876`	`addAttributes(attrs, range: textRange, updateLayout: updateLayout)`