Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 1d03a8f

Browse files
committedMar 18, 2025·
Revert "Fixup FIPS Makefile/E2E"
This reverts commit f67241a.
1 parent 28b5101 commit 1d03a8f

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed
 

‎Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ sub-push: all-image-registry push-manifest
194194

195195
.PHONY: sub-push-fips
196196
sub-push-fips:
197-
$(MAKE) FIPS=true TAG=$(TAG)-fips sub-push
197+
$(MAKE) FIPS=true sub-push
198198

199199
.PHONY: sub-push-a1compat
200200
sub-push-a1compat:

‎hack/e2e/build-image.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function build_and_push() {
6464
export ALL_OS="linux"
6565
export ALL_ARCH_linux="${IMAGE_ARCH}"
6666
fi
67-
make -j $(nproc) sub-push
67+
make -j $(nproc) all-push
6868

6969
loudecho "Image pushed to ${IMAGE_NAME}:${IMAGE_TAG}"
7070
}

‎hack/e2e/test-images.sh

+13-8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#!/bin/bash
2+
13
# Copyright 2025 The Kubernetes Authors.
24
#
35
# Licensed under the Apache License, Version 2.0 (the 'License');
@@ -34,10 +36,13 @@ function build_and_push() {
3436
MAX_IMAGES=10000
3537
IMAGE_COUNT=$(aws ecr list-images --repository-name "${IMAGE##*/}" --region "${REGION}" --query 'length(imageIds[])')
3638

37-
if [ $IMAGE_COUNT -ge $MAX_IMAGES ]; then
38-
loudecho "Repository image limit reached. Unable to push new images."
39-
exit 1
40-
fi
39+
loudecho "there are ${IMAGE_COUNT} images"
40+
41+
42+
# if [ $IMAGE_COUNT -ge $MAX_IMAGES ]; then
43+
# loudecho "Repository image limit reached. Unable to push new images."
44+
# exit 1
45+
# fi
4146

4247
loudecho "Building and pushing test driver images to ${IMAGE}:${IMAGE_TAG}"
4348
aws ecr get-login-password --region "${REGION}" | docker login --username AWS --password-stdin "${AWS_ACCOUNT_ID}.dkr.ecr.${REGION}.amazonaws.com"
@@ -51,7 +56,7 @@ function build_and_push() {
5156

5257
loudecho "Images pushed to ${IMAGE_NAME}:${IMAGE_TAG}"
5358
}
54-
59+
aws ecr delete-repository --repository-name aws-ebs-csi-driver --force
5560
REPO_CHECK=$(aws ecr describe-repositories --region "${AWS_REGION}")
5661
if [ $(jq ".repositories | map(.repositoryName) | index(\"${IMAGE_NAME##*/}\")" <<<"${REPO_CHECK}") == "null" ]; then
5762
aws ecr create-repository --region "${AWS_REGION}" --repository-name aws-ebs-csi-driver >/dev/null
@@ -68,18 +73,18 @@ imageSuffixes=("a1compat fips-windows-amd64-ltsc2022 fips-windows-amd64-ltsc2019
6873
loudecho "Ensuring all images are present"
6974

7075
for suffix in ${imageSuffixes[@]}; do
71-
if [ ! "$(crane digest "${IMAGE}":"${TAG}"-"${suffix}")" ]; then
76+
if [ ! "$(docker manifest inspect "${IMAGE}":"${TAG}"-"${suffix}")" ]; then
7277
loudecho "$suffix image not found"
7378
exit 1
7479
fi
7580
done
7681

7782
loudecho "Ensuring image indexes have all images"
78-
if [ ! "$(crane manifest ${IMAGE}:${TAG} | jq ".manifests.[3].platform")" ]; then
83+
if [ ! "$(docker manifest inspect ${IMAGE}:${TAG} | jq ".manifests.[3].platform")" ]; then
7984
loudecho "Error index image is missing images"
8085
exit 1
8186
fi
82-
if [ ! "$(crane manifest ${IMAGE}:${TAG}-fips | jq ".manifests.[3].platform")" ]; then
87+
if [ ! "$(docker manifest inspect ${IMAGE}:${TAG}-fips | jq ".manifests.[3].platform")" ]; then
8388
loudecho "Error fips index image is missing images"
8489
exit 1
8590
fi

0 commit comments

Comments
 (0)