change pod mutator webhook to fail-open (#4062)

M00nF1sh · web-flow · commit 9ab7f9dca57f · 2025-02-18T10:27:22.000-08:00
diff --git a/helm/aws-load-balancer-controller/templates/webhook.yaml b/helm/aws-load-balancer-controller/templates/webhook.yaml
@@ -19,7 +19,7 @@ webhooks:
       name: {{ template "aws-load-balancer-controller.webhookService" . }}
       namespace: {{ $.Release.Namespace }}
       path: /mutate-v1-pod
-  failurePolicy: Fail
+  failurePolicy: Ignore
   name: mpod.elbv2.k8s.aws
   admissionReviewVersions:
   - v1beta1
diff --git a/webhooks/core/pod_mutator.go b/webhooks/core/pod_mutator.go
@@ -44,7 +44,7 @@ func (m *podMutator) MutateUpdate(ctx context.Context, obj runtime.Object, oldOb
 	return obj, nil
 }
 
-// +kubebuilder:webhook:path=/mutate-v1-pod,mutating=true,failurePolicy=fail,groups="",resources=pods,verbs=create,versions=v1,name=mpod.elbv2.k8s.aws,sideEffects=None,webhookVersions=v1,admissionReviewVersions=v1beta1
+// +kubebuilder:webhook:path=/mutate-v1-pod,mutating=true,failurePolicy=ignore,groups="",resources=pods,verbs=create,versions=v1,name=mpod.elbv2.k8s.aws,sideEffects=None,webhookVersions=v1,admissionReviewVersions=v1beta1
 
 func (m *podMutator) SetupWithManager(mgr ctrl.Manager) {
 	mgr.GetWebhookServer().Register(apiPathMutatePod, webhook.MutatingWebhookForMutator(m, mgr.GetScheme()))

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ func (m *podMutator) MutateUpdate(ctx context.Context, obj runtime.Object, oldOb`
`44`	`44`	`return obj, nil`
`45`	`45`	`}`
`46`	`46`
`47`		`-// +kubebuilder:webhook:path=/mutate-v1-pod,mutating=true,failurePolicy=fail,groups="",resources=pods,verbs=create,versions=v1,name=mpod.elbv2.k8s.aws,sideEffects=None,webhookVersions=v1,admissionReviewVersions=v1beta1`
	`47`	`+// +kubebuilder:webhook:path=/mutate-v1-pod,mutating=true,failurePolicy=ignore,groups="",resources=pods,verbs=create,versions=v1,name=mpod.elbv2.k8s.aws,sideEffects=None,webhookVersions=v1,admissionReviewVersions=v1beta1`
`48`	`48`
`49`	`49`	`func (m *podMutator) SetupWithManager(mgr ctrl.Manager) {`
`50`	`50`	`mgr.GetWebhookServer().Register(apiPathMutatePod, webhook.MutatingWebhookForMutator(m, mgr.GetScheme()))`