Skip to content

Commit c6b2def

Browse files
authored
add uts for setProviderID (#2144)
1 parent a1ae38b commit c6b2def

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

cloud/scope/machine_test.go

+14-2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3131
"k8s.io/client-go/kubernetes/scheme"
3232
"k8s.io/klog/v2"
33+
"k8s.io/utils/ptr"
3334
capiv1beta1 "sigs.k8s.io/cluster-api/api/v1beta1"
3435
"sigs.k8s.io/controller-runtime/pkg/client"
3536
"sigs.k8s.io/controller-runtime/pkg/client/fake"
@@ -133,7 +134,7 @@ func TestSetVPCProviderID(t *testing.T) {
133134
g := NewWithT(t)
134135
scope := setupMachineScope(clusterName, machineName, mock.NewMockVpc(gomock.NewController(t)))
135136
options.ProviderIDFormat = string("v1")
136-
err := scope.SetProviderID(core.StringPtr(providerID))
137+
err := scope.SetProviderID(ptr.To(providerID))
137138
g.Expect(err).ToNot(BeNil())
138139
})
139140

@@ -144,9 +145,20 @@ func TestSetVPCProviderID(t *testing.T) {
144145
utils.GetAccountIDFunc = func() (string, error) {
145146
return "dummy-account-id", nil // Return dummy value
146147
}
147-
err := scope.SetProviderID(core.StringPtr(providerID))
148+
err := scope.SetProviderID(ptr.To(providerID))
148149
g.Expect(err).To(BeNil())
149150
})
151+
152+
t.Run("Set Provider ID returns error", func(t *testing.T) {
153+
g := NewWithT(t)
154+
scope := setupMachineScope(clusterName, machineName, mock.NewMockVpc(gomock.NewController(t)))
155+
options.ProviderIDFormat = string("v2")
156+
utils.GetAccountIDFunc = func() (string, error) {
157+
return "", errors.New("error getting accountID") // Return dummy error
158+
}
159+
err := scope.SetProviderID(ptr.To(providerID))
160+
g.Expect(err).NotTo(BeNil())
161+
})
150162
}
151163

152164
func TestCreateMachine(t *testing.T) {

0 commit comments

Comments
 (0)