Skip to content

Commit dad28ba

Browse files
fix powervs_cloud_controller image build (#2188)
Signed-off-by: Prajyot-Parab <[email protected]>
1 parent 9b28606 commit dad28ba

File tree

1 file changed

+17
-31
lines changed

1 file changed

+17
-31
lines changed

hack/ccm/Makefile

+17-31
Original file line numberDiff line numberDiff line change
@@ -20,48 +20,34 @@ REGISTRY=gcr.io/k8s-staging-capi-ibmcloud
2020
IMG=powervs-cloud-controller-manager
2121

2222
# POWERVS_CLOUD_CONTROLLER_COMMIT can be fetched from here https://github.com/openshift/cloud-provider-powervs/commits/main
23-
POWERVS_CLOUD_CONTROLLER_COMMIT?=7c51cd2
23+
POWERVS_CLOUD_CONTROLLER_COMMIT?=0b19baf
2424
TAG?=$(POWERVS_CLOUD_CONTROLLER_COMMIT)
2525

2626
build-image-linux-amd64: init-buildx
27-
{ \
28-
set -e ; \
27+
{ \
28+
set -e ; \
2929
docker buildx build \
30-
--build-arg golang_image=$(GO_CONTAINER_IMAGE)\
30+
--build-arg golang_image=$(GO_CONTAINER_IMAGE) \
3131
--build-arg TARGETPLATFORM=linux/amd64 --build-arg ARCH=amd64 \
32-
--build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT)\
33-
-t $(REGISTRY)/$(IMG):$(TAG)_linux_amd64 . --target centos-base; \
32+
--build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT) \
33+
-t $(REGISTRY)/$(IMG):$(TAG)_linux_amd64 . --load --target centos-base; \
3434
}
3535

3636
build-image-linux-ppc64le: init-buildx
37-
{ \
38-
set -e ; \
37+
{ \
38+
set -e ; \
3939
docker buildx build \
40-
--build-arg golang_image=$(GO_CONTAINER_IMAGE)\
41-
--build-arg TARGETPLATFORM=linux/ppc64le --build-arg ARCH=ppc64le\
42-
--build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT)\
43-
-t $(REGISTRY)/$(IMG):$(TAG)_linux_ppc64le . --target centos-base; \
40+
--build-arg golang_image=$(GO_CONTAINER_IMAGE) \
41+
--build-arg TARGETPLATFORM=linux/ppc64le --build-arg ARCH=ppc64le \
42+
--build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT) \
43+
-t $(REGISTRY)/$(IMG):$(TAG)_linux_ppc64le . --load --target centos-base; \
4444
}
4545

46-
build-image-and-push-linux-amd64: init-buildx
47-
{ \
48-
set -e ; \
49-
docker buildx build \
50-
--build-arg golang_image=$(GO_CONTAINER_IMAGE)\
51-
--build-arg TARGETPLATFORM=linux/amd64 --build-arg ARCH=amd64 \
52-
--build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT)\
53-
-t $(REGISTRY)/$(IMG):$(TAG)_linux_amd64 . --push --target centos-base; \
54-
}
46+
build-image-and-push-linux-amd64: build-image-linux-amd64
47+
docker push $(REGISTRY)/$(IMG):$(TAG)_linux_amd64
5548

56-
build-image-and-push-linux-ppc64le: init-buildx
57-
{ \
58-
set -e ; \
59-
docker buildx build \
60-
--build-arg golang_image=$(GO_CONTAINER_IMAGE)\
61-
--build-arg TARGETPLATFORM=linux/ppc64le --build-arg ARCH=ppc64le\
62-
--build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT)\
63-
-t $(REGISTRY)/$(IMG):$(TAG)_linux_ppc64le . --push --target centos-base; \
64-
}
49+
build-image-and-push-linux-ppc64le: build-image-linux-ppc64le
50+
docker push $(REGISTRY)/$(IMG):$(TAG)_linux_ppc64le
6551

6652
init-buildx:
6753
# Ensure we use a builder that can leverage it (the default on linux will not)
@@ -75,4 +61,4 @@ init-buildx:
7561

7662
build-and-push-multi-arch: build-image-and-push-linux-amd64 build-image-and-push-linux-ppc64le
7763
docker manifest create --amend $(REGISTRY)/$(IMG):$(TAG) $(REGISTRY)/$(IMG):$(TAG)_linux_amd64 $(REGISTRY)/$(IMG):$(TAG)_linux_ppc64le
78-
docker manifest push -p $(REGISTRY)/$(IMG):$(TAG)
64+
docker manifest push $(REGISTRY)/$(IMG):$(TAG)

0 commit comments

Comments
 (0)