Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference links for environment variables for VPC and PowerVS #2172

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add reference links for environment variables for VPC and PowerVS #2172

wants to merge 6 commits into from
+25 −2

Conversation

arshadd-b
Copy link
Contributor

@arshadd-b arshadd-b commented Feb 5, 2025 •
edited by mkumatag
Loading

What this PR does / why we need it:
This PR adds details for environment variables for VPC and PowerVS in CAPIBM book
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes: #2133
Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add reference  links for environment variables for  VPC and PowerVS

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud processing.

Name Link
🔨 Latest commit b3a285f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67d428a380bfeb0008c23d1b

@Prajyot-Parab
Copy link
Contributor

@Karthik-K-N I feel this approach is too repetitive, would it be better to have a single place with everything and point just to that?

@Amulyam24
Copy link
Contributor

@Karthik-K-N I feel this approach is too repetitive, would it be better to have a single place with everything and point just to that?

+1

@Karthik-K-N
Copy link
Contributor

Sure, Please go ahead with whatever you feel will make the doc more understandable.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2025
@arshadd-b arshadd-b force-pushed the env-description branch 2 times, most recently from 633bfac to 61cb664 Compare February 6, 2025 13:44
@Amulyam24
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 7, 2025
@arshadd-b arshadd-b force-pushed the env-description branch 5 times, most recently from 2703f0c to 7970445 Compare March 5, 2025 08:26
@arshadd-b
Copy link
Contributor Author

/retest

@arshadd-b arshadd-b requested a review from Amulyam24 March 6, 2025 05:06
@arshadd-b
Copy link
Contributor Author

/retest

@arshadd-b
Copy link
Contributor Author

Hi @Amulyam24 , I have addressed the review comments. Please have a look. Thanks

@Amulyam24
Copy link
Contributor

/retest

Amulyam24
Amulyam24 reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments otherwise overall LGTM!

@arshadd-b arshadd-b requested a review from Amulyam24 March 13, 2025 16:19
@arshadd-b
Copy link
Contributor Author

Minor comments otherwise overall LGTM!

Hi @Amulyam24 have addressed review comments. Please have a look. Thanks

@Amulyam24
Copy link
Contributor

/retest

Amulyam24
Amulyam24 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @arshadd-b!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
Prajyot-Parab
Prajyot-Parab approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, arshadd-b, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

Assignees

@Amulyam24 Amulyam24

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a description for environametal variable used in cluster create template
5 participants
@arshadd-b @k8s-ci-robot @Prajyot-Parab @Amulyam24 @Karthik-K-N