Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 v1beta2: implement VSphereCluster's Ready, FailureDomainsReady, ClusterModulesReady and VCenterAvailable conditions for govmomi #3396

Merged
merged 4 commits into from
Mar 19, 2025
Merged

🌱 v1beta2: implement VSphereCluster's Ready, FailureDomainsReady, ClusterModulesReady and VCenterAvailable conditions for govmomi #3396

merged 4 commits into from
Mar 19, 2025

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Implements the following v1beta2 conditions for govmomi mode's VSphereCluster

  • Ready
  • FailureDomainsReady
  • ClusterModulesReady
  • VCenterAvailable

Part of #3221

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from srm09 and vrabbi March 17, 2025 10:58
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 17, 2025
@chrischdi
Copy link
Member Author

/hold

For rebase after

merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2025
@chrischdi chrischdi mentioned this pull request Mar 17, 2025
Closed
8 tasks
@chrischdi chrischdi force-pushed the pr-govmomi-vspherecluster branch 3 times, most recently from c052885 to ed5924a Compare March 17, 2025 12:01
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2025
@chrischdi chrischdi force-pushed the pr-govmomi-vspherecluster branch from ed5924a to dd8d3d6 Compare March 17, 2025 12:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2025
@chrischdi chrischdi changed the title 🌱 [wip] v1beta2: implement VSphereCluster's Ready, FailureDomainsReady, ClusterModulesReady and VCenterAvailable conditions for govmomi 🌱 v1beta2: implement VSphereCluster's Ready, FailureDomainsReady, ClusterModulesReady and VCenterAvailable conditions for govmomi Mar 17, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2025
@chrischdi chrischdi force-pushed the pr-govmomi-vspherecluster branch from dd8d3d6 to 70e9fbb Compare March 17, 2025 12:23
@chrischdi chrischdi mentioned this pull request Mar 17, 2025
Closed
@chrischdi
Copy link
Member Author

/hold

Waiting for CI at:

@chrischdi chrischdi force-pushed the pr-govmomi-vspherecluster branch from 70e9fbb to d219994 Compare March 17, 2025 12:42
sbueringer
sbueringer reviewed Mar 17, 2025
View reviewed changes
@chrischdi chrischdi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 17, 2025
@chrischdi
Copy link
Member Author

/retest

Image pull failure while building kind image

@chrischdi
vspherecluster: implement Ready, FailureDomainsReady, ClusterModulesR…
58e9cba 
…eady and VCenterAvailable v1beta2 conditions for govmomi
@chrischdi
fixes
a88b513
@chrischdi chrischdi force-pushed the pr-govmomi-vspherecluster branch from 8333790 to a88b513 Compare March 18, 2025 10:12
sbueringer
sbueringer reviewed Mar 18, 2025
View reviewed changes
@sbueringer
Copy link
Member

Thx!

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a4608be7aa736b22d9d981c501cc16451677f4fe

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@sbueringer
Copy link
Member

/lgtm
/approve

Keeping hold for CI

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d7e90846434a0bed54c067821c42205e7542aef9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main 121671d link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 68be3e5 into kubernetes-sigs:main Mar 19, 2025
13 of 14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 Awaiting requested review from srm09

@vrabbi vrabbi Awaiting requested review from vrabbi

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @sbueringer @k8s-ci-robot @fabriziopandini