Skip to content

Commit 046588d

Browse files
committed
enable requiredfields linter
Signed-off-by: sivchari <[email protected]>
1 parent e95ff05 commit 046588d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.golangci-kal.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@ linters-settings:
1818
enable:
1919
- "conditions" # Ensure conditions have the correct json tags and markers.
2020
- "integers" # Ensure only int32 and int64 are used for integers.
21-
- "statussubresource" # All root objects that have a `status` field should have a status subresource.
22-
- "nofloats" # Ensure floats are not used.
2321
- "maxlength" # Ensure all strings and arrays have maximum lengths/maximum items.
2422
- "nobools" # Bools do not evolve over time, should use enums instead.
23+
- "nofloats" # Ensure floats are not used.
24+
- "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
25+
- "statussubresource" # All root objects that have a `status` field should have a status subresource.
2526

2627
# Per discussion in July 2024, we are keeping phase fields for now.
2728
# See https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685929508
@@ -32,7 +33,6 @@ linters-settings:
3233
# - "commentstart" # Ensure comments start with the serialized version of the field name.
3334
# - "jsontags" # Ensure every field has a json tag.
3435
# - "optionalorrequired" # Every field should be marked as `+optional` or `+required`.
35-
# - "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
3636
disable:
3737
- "*" # We will manually enable new linters after understanding the impact. Disable all by default.
3838
lintersConfig:

0 commit comments

Comments
 (0)