Skip to content

Commit 090dc80

Browse files
authored
Merge pull request #11800 from sbueringer/pr-order-ginkgo
🌱 test/e2e: order ginkgo flags, add --fail-on-pending --fail-on-empty, increase timeout to 3h
2 parents c3ed535 + a8a7a8e commit 090dc80

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

Makefile

+13-8
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ GINKGO_FOCUS ?=
8181
GINKGO_SKIP ?=
8282
GINKGO_LABEL_FILTER ?=
8383
GINKGO_NODES ?= 1
84-
GINKGO_TIMEOUT ?= 2h
84+
GINKGO_TIMEOUT ?= 3h
85+
GINKGO_ARGS ?=
8586
GINKGO_POLL_PROGRESS_AFTER ?= 60m
8687
GINKGO_POLL_PROGRESS_INTERVAL ?= 5m
8788
E2E_CONF_FILE ?= $(ROOT_DIR)/$(TEST_DIR)/e2e/config/docker.yaml
@@ -973,13 +974,17 @@ test-test-extension-junit: $(SETUP_ENVTEST) $(GOTESTSUM) ## Run unit and integra
973974

974975
.PHONY: test-e2e
975976
test-e2e: $(GINKGO) generate-e2e-templates ## Run the end-to-end tests
976-
$(GINKGO) -v --trace -poll-progress-after=$(GINKGO_POLL_PROGRESS_AFTER) \
977-
-poll-progress-interval=$(GINKGO_POLL_PROGRESS_INTERVAL) --tags=e2e --focus="$(GINKGO_FOCUS)" --label-filter="$(GINKGO_LABEL_FILTER)" \
978-
$(_SKIP_ARGS) --nodes=$(GINKGO_NODES) --timeout=$(GINKGO_TIMEOUT) --no-color=$(GINKGO_NOCOLOR) \
979-
--output-dir="$(ARTIFACTS)" --junit-report="junit.e2e_suite.1.xml" $(GINKGO_ARGS) $(ROOT_DIR)/$(TEST_DIR)/e2e -- \
980-
-e2e.artifacts-folder="$(ARTIFACTS)" \
981-
-e2e.config="$(E2E_CONF_FILE)" \
982-
-e2e.skip-resource-cleanup=$(SKIP_RESOURCE_CLEANUP) -e2e.use-existing-cluster=$(USE_EXISTING_CLUSTER)
977+
$(GINKGO) -v --trace --tags=e2e \
978+
--nodes=$(GINKGO_NODES) --timeout=$(GINKGO_TIMEOUT) \
979+
--label-filter="$(GINKGO_LABEL_FILTER)" --focus="$(GINKGO_FOCUS)" $(_SKIP_ARGS) \
980+
--poll-progress-after=$(GINKGO_POLL_PROGRESS_AFTER) --poll-progress-interval=$(GINKGO_POLL_PROGRESS_INTERVAL) \
981+
--fail-on-pending --fail-on-empty \
982+
--no-color=$(GINKGO_NOCOLOR) --output-dir="$(ARTIFACTS)" --junit-report="junit.e2e_suite.1.xml" \
983+
$(GINKGO_ARGS) ./test/e2e -- \
984+
--e2e.artifacts-folder="$(ARTIFACTS)" \
985+
--e2e.config="$(E2E_CONF_FILE)" \
986+
--e2e.skip-resource-cleanup=$(SKIP_RESOURCE_CLEANUP) \
987+
--e2e.use-existing-cluster=$(USE_EXISTING_CLUSTER)
983988

984989

985990
.PHONY: kind-cluster

0 commit comments

Comments
 (0)