enable requiredfields linter

Signed-off-by: sivchari <[email protected]>

Author: sivchari

.golangci-kal.yml

@@ -18,6 +18,7 @@ linters-settings:
           enable:
           - "conditions" # Ensure conditions have the correct json tags and markers.
           - "integers" # Ensure only int32 and int64 are used for integers.
+          - "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
 
           # Per discussion in July 2024, we are keeping phase fields for now.
           # See https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685929508
@@ -30,7 +31,6 @@ linters-settings:
           # - "maxlength" # Ensure all strings and arrays have maximum lengths/maximum items.
           # - "nobools" # Bools do not evolve over time, should use enums instead.
           # - "optionalorrequired" # Every field should be marked as `+optional` or `+required`.
-          # - "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
           # - "statussubresource" # All root objects that have a `status` field should have a status subresource.
           disable:
           - "*" # We will manually enable new linters after understanding the impact. Disable all by default.
@@ -44,8 +44,6 @@ linters-settings:
         # optionalOrRequired:
         #   preferredOptionalMarker: optional | kubebuilder:validation:Optional # The preferred optional marker to use, fixes will suggest to use this marker. Defaults to `optional`.
         #   preferredRequiredMarker: required | kubebuilder:validation:Required # The preferred required marker to use, fixes will suggest to use this marker. Defaults to `required`.
-        # requiredFields:
-        #   pointerPolicy: Warn | SuggestFix # Defaults to `SuggestFix`. We want our required fields to not be pointers.
 
 issues:
   exclude-files: