Skip to content

Commit 8fcde6a

Browse files
authoredDec 2, 2024··
Merge pull request #11472 from fabriziopandini/deprecate-ProgressDeadlineSeconds
⚠️ Deprecate MD.Spec.ProgressDeadlineSeconds
2 parents d8d4920 + 42297c1 commit 8fcde6a

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed
 

‎.golangci.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,11 @@ issues:
244244
- linters:
245245
- staticcheck
246246
text: "SA1019: ((deployment|m|md).Spec.RevisionHistoryLimit|clusterv1.RevisionHistoryAnnotation|c.RolloutUndo) is deprecated"
247-
# Deprecations for MHC MaxUnhealthy, UnhealthyRange
247+
# Deprecations for MD revision management
248+
- linters:
249+
- staticcheck
250+
text: "SA1019: (m|md).Spec.ProgressDeadlineSeconds is deprecated: This field is deprecated and is going to be removed in the next apiVersion. Please see https://github.com/kubernetes-sigs/cluster-api/issues/11470 for more details."
251+
# Deprecations for MHC MaxUnhealthy, UnhealthyRange
248252
- linters:
249253
- staticcheck
250254
text: "SA1019: (mhc|m)(.Spec.MaxUnhealthy|.Spec.UnhealthyRange) is deprecated"

‎api/v1beta1/machinedeployment_types.go

+3
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,9 @@ type MachineDeploymentSpec struct {
308308
// process failed deployments and a condition with a ProgressDeadlineExceeded
309309
// reason will be surfaced in the deployment status. Note that progress will
310310
// not be estimated during the time a deployment is paused. Defaults to 600s.
311+
//
312+
// Deprecated: This field is deprecated and is going to be removed in the next apiVersion. Please see https://github.com/kubernetes-sigs/cluster-api/issues/11470 for more details.
313+
//
311314
// +optional
312315
ProgressDeadlineSeconds *int32 `json:"progressDeadlineSeconds,omitempty"`
313316
}

‎api/v1beta1/zz_generated.openapi.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎config/crd/bases/cluster.x-k8s.io_machinedeployments.yaml

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.